fix(ui) changed drawer to follow expected behavior for auto closing - #11491
Open
itsSiide wants to merge 2 commits into
Open
fix(ui) changed drawer to follow expected behavior for auto closing#11491itsSiide wants to merge 2 commits into
itsSiide wants to merge 2 commits into
Conversation
Contributor
|
✅ Validation Passed: All report and feature-flag labels are correctly set. |
Author
|
i cannot assign labels myself, could anyone tag this with report include ? |
-Added a state change to selection of an account -Changed the AvatarLayout click event to make the whole box clickable for account selection -Added a new test to confirm drawer close behavior
-Added missing spotlessApply to the test File
itsSiide
force-pushed
the
fix-issue-11461
branch
from
September 4, 2026 10:04
8fb41a1 to
f6009cb
Compare
Author
|
I fixed the spotless application for the test file and updated the merge from today morning. Should be good to go now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Added a state change to selection of an account
-Changed the AvatarLayout click event to make the whole box clickable for account selection
-Added a new test to confirm drawer close behavior
Contribution Summary
Linked Issue/Ticket: #11461
RFC / Technical Design (if applicable): n/a
Description
The drawer previously properly closed itself after selecting a user account but the expanded account selection was still expanded even after the drawer has already been closed. I fixed this by setting the state correctly before emitting the drawer close event. This only applies when the auto select folders account setting is set to anything but "none". If "none" is selected the account selection closes and the drawer still remains open.
I also adjusted the second stated Problem with the avatar icon not being clickable while selecting an account. This was the case due to the AvatarLayout always setting an onClick event even though it may be initialized without one by the caller. This caused the icon to just take up the click and doing nothing with it. I changed the modifier to only be set when an onClick is explicitly given.
A Test to confirm the changed account selection drawer behavior was added as well.
Screen Shots
Nothing visual was changed, just ui behavior.
AI Disclosure
Select one of the following (mandatory)
Contribution Checklist
gradlew spotlessCheckto check andgradlew spotlessApplyto format your source code; will be checked by CI).gradlew testDebugUnitTest; will be checked by CI).