Skip to content

fix(ui) changed drawer to follow expected behavior for auto closing - #11491

Open
itsSiide wants to merge 2 commits into
thunderbird:mainfrom
itsSiide:fix-issue-11461
Open

fix(ui) changed drawer to follow expected behavior for auto closing#11491
itsSiide wants to merge 2 commits into
thunderbird:mainfrom
itsSiide:fix-issue-11461

Conversation

@itsSiide

@itsSiide itsSiide commented Sep 3, 2026

Copy link
Copy Markdown

-Added a state change to selection of an account
-Changed the AvatarLayout click event to make the whole box clickable for account selection
-Added a new test to confirm drawer close behavior

Contribution Summary

Linked Issue/Ticket: #11461

RFC / Technical Design (if applicable): n/a

Description

The drawer previously properly closed itself after selecting a user account but the expanded account selection was still expanded even after the drawer has already been closed. I fixed this by setting the state correctly before emitting the drawer close event. This only applies when the auto select folders account setting is set to anything but "none". If "none" is selected the account selection closes and the drawer still remains open.

I also adjusted the second stated Problem with the avatar icon not being clickable while selecting an account. This was the case due to the AvatarLayout always setting an onClick event even though it may be initialized without one by the caller. This caused the icon to just take up the click and doing nothing with it. I changed the modifier to only be set when an onClick is explicitly given.

A Test to confirm the changed account selection drawer behavior was added as well.

Screen Shots

Nothing visual was changed, just ui behavior.

AI Disclosure

Select one of the following (mandatory)

  • This contribution does not include any changes created or assisted by AI.
  • This contribution includes changes assisted by AI.
  • This contribution includes changes created by AI.

Contribution Checklist

  • I have read and affirm that my contribution adheres to Mozilla’s Community Participation Guidelines
  • This contribution is in Kotlin where possible
  • This contribution does not use merge commits
  • This contribution adheres to the existing codestyle (run gradlew spotlessCheck to check and gradlew spotlessApply to format your source code; will be checked by CI).
  • This contribution does not break existing unit tests (run gradlew testDebugUnitTest; will be checked by CI).
  • This contribution includes tests for any new functionality, and maintains tests for any updated functionality.
  • This contribution adheres to our Engineering process (RFC/Technical Design/ADR)
  • This PR has a descriptive title and body that accurately outlines all changes made, and contains a reference to any issues that it fixes (e.g. Closes #XXX or Fixes #XXX).

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Validation Passed: All report and feature-flag labels are correctly set.

@itsSiide

itsSiide commented Sep 3, 2026

Copy link
Copy Markdown
Author

i cannot assign labels myself, could anyone tag this with report include ?

@wmontwe wmontwe added the report: include Include changes in user-facing reports. label Sep 4, 2026
-Added a state change to selection of an account
-Changed the AvatarLayout click event to make the whole box clickable for account selection
-Added a new test to confirm drawer close behavior
-Added missing spotlessApply to the test File
@itsSiide

itsSiide commented Sep 4, 2026

Copy link
Copy Markdown
Author

I fixed the spotless application for the test file and updated the merge from today morning. Should be good to go now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

report: include Include changes in user-facing reports.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants