Skip to content

refactor(db-repository): extract push folders query logic to PushFoldersQueryRepository - #11479

Merged
rafaeltonholo merged 1 commit into
mainfrom
chore/11470/split-folder-repository-part-2
Sep 4, 2026
Merged

refactor(db-repository): extract push folders query logic to PushFoldersQueryRepository#11479
rafaeltonholo merged 1 commit into
mainfrom
chore/11470/split-folder-repository-part-2

Conversation

@rafaeltonholo

Copy link
Copy Markdown
Member

Contribution Summary

Linked Issue/Ticket: Part of #11470

Description

  • Add PushFoldersQueryRepository interface with observeAllByAccountId and getAllByAccountId methods
  • Add DefaultPushFoldersQueryRepository implementation
  • Remove getPushFoldersFlow and getPushFolders from FolderRepository
  • Update AccountPushController to use new repository and handle Outcome
  • Add comprehensive tests for DefaultPushFoldersQueryRepository

AI Disclosure

Select one of the following (mandatory)

  • This contribution does not include any changes created or assisted by AI.
  • This contribution includes changes assisted by AI.
  • This contribution includes changes created by AI.

Contribution Checklist

  • I have read and affirm that my contribution adheres to Mozilla’s Community Participation Guidelines
  • This contribution is in Kotlin where possible
  • This contribution does not use merge commits
  • This contribution adheres to the existing codestyle (run gradlew spotlessCheck to check and gradlew spotlessApply to format your source code; will be checked by CI).
  • This contribution does not break existing unit tests (run gradlew testDebugUnitTest; will be checked by CI).
  • This contribution includes tests for any new functionality, and maintains tests for any updated functionality.
  • This contribution adheres to our Engineering process (RFC/Technical Design/ADR)
  • This PR has a descriptive title and body that accurately outlines all changes made, and contains a reference to any issues that it fixes (e.g. Closes #XXX or Fixes #XXX).

Stack created with GitHub Stacks CLIGive Feedback 💬

@rafaeltonholo
rafaeltonholo requested a review from a team as a code owner September 1, 2026 16:07
@rafaeltonholo
rafaeltonholo requested review from dani-zilla and removed request for a team September 1, 2026 16:07
@rafaeltonholo rafaeltonholo added the report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). label Sep 1, 2026
@github-actions github-actions Bot added the tb-team Tasks and features handled by project maintainers label Sep 1, 2026
@rafaeltonholo
rafaeltonholo force-pushed the chore/11470/split-folder-repository-part-2 branch from aa80dc0 to 5b1741f Compare September 2, 2026 10:50
@rafaeltonholo rafaeltonholo added the pr: stacked Must be used on a PR that is stacked on top of other(s) label Sep 2, 2026
@rafaeltonholo
rafaeltonholo force-pushed the chore/11470/split-folder-repository-part-2 branch from 5b1741f to edbd36f Compare September 3, 2026 14:16
Base automatically changed from chore/11470/split-folder-repository to main September 4, 2026 10:49
…ueryRepository

- Add PushFoldersQueryRepository interface with observeAllByAccountId and getAllByAccountId methods
- Add DefaultPushFoldersQueryRepository implementation
- Remove getPushFoldersFlow and getPushFolders from FolderRepository
- Update AccountPushController to use new repository and handle Outcome
- Add comprehensive tests for DefaultPushFoldersQueryRepository
@rafaeltonholo
rafaeltonholo force-pushed the chore/11470/split-folder-repository-part-2 branch from edbd36f to a066b1f Compare September 4, 2026 10:49
@rafaeltonholo
rafaeltonholo merged commit 7fb13f7 into main Sep 4, 2026
19 checks passed
@rafaeltonholo
rafaeltonholo deleted the chore/11470/split-folder-repository-part-2 branch September 4, 2026 18:31
@thunderbird-botmobile thunderbird-botmobile Bot added this to the Thunderbird 25 milestone Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: stacked Must be used on a PR that is stacked on top of other(s) report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). tb-team Tasks and features handled by project maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants