Skip to content

chore(feature-flag): feature flag legacy code cleanup - #11451

Open
rafaeltonholo wants to merge 2 commits into
thunderbird:mainfrom
rafaeltonholo:chore/11337/remove-legacy-feature-flag-implementation
Open

chore(feature-flag): feature flag legacy code cleanup#11451
rafaeltonholo wants to merge 2 commits into
thunderbird:mainfrom
rafaeltonholo:chore/11337/remove-legacy-feature-flag-implementation

Conversation

@rafaeltonholo

Copy link
Copy Markdown
Member

Contribution Summary

Linked Issue/Ticket: Closes #11337

RFC / Technical Design (if applicable): RFC 0004: Add a Declarative Feature Flag Catalog / Technical Design 0002: Declarative Feature Flag Catalog

Description

Remove all the legacy code from the old Feature Flag Architecture.

AI Disclosure

Select one of the following (mandatory)

  • This contribution does not include any changes created or assisted by AI.
  • This contribution includes changes assisted by AI.
  • This contribution includes changes created by AI.

Contribution Checklist

  • I have read and affirm that my contribution adheres to Mozilla’s Community Participation Guidelines
  • This contribution is in Kotlin where possible
  • This contribution does not use merge commits
  • This contribution adheres to the existing codestyle (run gradlew spotlessCheck to check and gradlew spotlessApply to format your source code; will be checked by CI).
  • This contribution does not break existing unit tests (run gradlew testDebugUnitTest; will be checked by CI).
  • This contribution includes tests for any new functionality, and maintains tests for any updated functionality.
  • This contribution adheres to our Engineering process (RFC/Technical Design/ADR)
  • This PR has a descriptive title and body that accurately outlines all changes made, and contains a reference to any issues that it fixes (e.g. Closes #XXX or Fixes #XXX).

@rafaeltonholo
rafaeltonholo requested a review from a team as a code owner August 25, 2026 14:50
@rafaeltonholo
rafaeltonholo requested a review from wmontwe August 25, 2026 14:50
@rafaeltonholo rafaeltonholo added the report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). label Aug 25, 2026
@github-actions github-actions Bot added the tb-team Tasks and features handled by project maintainers label Aug 25, 2026
wmontwe
wmontwe previously approved these changes Aug 25, 2026

@wmontwe wmontwe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeltonholo
rafaeltonholo force-pushed the chore/11337/remove-legacy-feature-flag-implementation branch from d9f75ba to 8789e20 Compare August 25, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). tb-team Tasks and features handled by project maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Flag — Declarative catalog — Remove the legacy factory implementation

2 participants