Skip to content

fix(recipient-completion): show which suggestion the keyboard has selected #11416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rafaeltonholo merged 1 commit into from
Aug 25, 2026
+40 −0
Merged

fix(recipient-completion): show which suggestion the keyboard has selected #11416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions legacy/ui/legacy/src/main/res/drawable/recipient_dropdown_item_background.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<?xml version="1.0" encoding="utf-8"?>
<!--
Marks the recipient completion suggestion that the keyboard has selected.

The selection has to be drawn by the row rather than by the list selector. ListView.setupChild() calls
child.setSelected() on the row, which is correct from the first selection onwards, whereas the selector's
drawable state is the list's own state (AbsListView.getDrawableStateForSelector) and DropDownListView
reports itself as focused for as long as the popup exists, so a stateful selector cannot tell a selected
row from a cleared one. The list selector is deliberately left alone, so touch feedback is unchanged.

The fill on its own is only 1.22:1 against the popup background in the light theme, so the outline carries
the contrast: colorPrimary is 7.7:1 there and 14.1:1 in the dark theme. colorSecondaryContainer, the
Material token for a selected list item, is not usable here because the rows take their text colour from
textColorPrimaryRecipientDropdown, which is pinned to black in the light theme and reaches only 3.3:1 on it.

Note that state_selected also propagates to the row's TextViews. It does not change their colour today
because @android:color/primary_text_* matches its state_window_focused="false" entry first, and this popup
is never focusable, but making the popup focusable would turn the selected row's text black on black.
-->
<selector xmlns:android="http://schemas.android.com/apk/res/android">

<item android:state_selected="true">
<inset android:inset="2dp">
<shape android:shape="rectangle">
<solid android:color="?attr/colorSurfaceContainerHighest" />
<stroke
android:width="2dp"
android:color="?attr/colorPrimary"
/>
<corners android:radius="4dp" />
</shape>
</inset>
</item>

<item>
<color android:color="@android:color/transparent" />
</item>

</selector>
1 change: 1 addition & 0 deletions legacy/ui/legacy/src/main/res/layout/recipient_dropdown_item.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
android:minHeight="?android:listPreferredItemHeight"
android:gravity="center"
android:orientation="horizontal"
android:background="@drawable/recipient_dropdown_item_background"
>

<de.hdodenhof.circleimageview.CircleImageView
Expand Down
Loading