fix(widget): use theme-aware background for message list widget - #11406
Open
chrisdebian wants to merge 1 commit into
Open
fix(widget): use theme-aware background for message list widget#11406chrisdebian wants to merge 1 commit into
chrisdebian wants to merge 1 commit into
Conversation
The message-list home screen widget's ListView background was hardcoded to @android:color/white, with no drawable-night/values-night variant anywhere in the module. In dark mode this renders as a stark white list against the rest of the (dark) home screen. Switched to ?android:attr/colorBackground, matching the pattern the widget's own thread_count TextView already uses correctly for its text colour.
Contributor
|
Missing report label. Set exactly one of: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Summary
Linked Issue/Ticket: (none — found during ad-hoc dark-mode testing, not filed as a separate issue)
Description
The message-list home screen widget's ListView background was hardcoded to
@android:color/white, and there's nodrawable-night/values-nightvariant anywhere in the widget module. In dark mode this renders as a stark
white list against the rest of a dark-themed home screen.
Switched to
?android:attr/colorBackground, matching the pattern thewidget's own
thread_countTextView already uses correctly for its textcolour (
android:textColor="?android:attr/colorBackground") — so the fixfollows an existing, working convention in the same file rather than
introducing a new one.
Screen Shots
Confirmed on a real Pixel 10: adding the widget with the device in dark
mode showed a stark white row (screenshot on request). Not yet
re-verified against a built APK with this exact fix applied — a full app
build takes considerably longer than the module-level checks below; happy
to do that pass too if useful.
AI Disclosure
Contribution Checklist
spotlessCheckran clean on:feature:widget:message-list)testDebugUnitTest— NO-SOURCE, module has no unit tests)