Introduce vendor namespace support#6
Conversation
Adds a `vendor` option to ThunderIDConfig so adopters can white-label the SDK's runtime identifiers (EncryptedSharedPreferences file name, Compose i18n locale storage key) instead of being pinned to the `thunderid` brand prefix. Also drops a brand-specific log tag in favor of a generic one. Related: thunder-id/thunderid#3896
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Purpose
ThunderIDis hardcoded in some SDK components, making it hard for adopters to white-label the SDK. Mirrors the approach landed in thunder-id/javascript-sdks#24.Approach
vendoroption toThunderIDConfig(defaults toThunderIDConfig.DEFAULT_VENDOR,"thunderid").EncryptedStorageAdapternow accepts aprefsNameoverride so callers can derive the EncryptedSharedPreferences file name fromconfig.vendor.ThunderIDProvider(Compose) now resolves the i18n locale storage key fromconfig.vendorwhen no explicitThunderIDI18nis supplied."ThunderID:SignIn"log tag with a generic"SignInFlow"tag, since the brand prefix wasn't load-bearing there.AGENTS.mdso future changes keep runtime keys/names vendor-aware.Related Issues
Checklist
./gradlew compileDebugKotlinpasses../gradlew ktlintCheckpasses with 0 violations.