Skip to content

Introduce vendor namespace support#6

Open
brionmario wants to merge 1 commit into
thunder-id:mainfrom
brionmario:flexible-vendor-config
Open

Introduce vendor namespace support#6
brionmario wants to merge 1 commit into
thunder-id:mainfrom
brionmario:flexible-vendor-config

Conversation

@brionmario

Copy link
Copy Markdown
Member

Purpose

ThunderID is hardcoded in some SDK components, making it hard for adopters to white-label the SDK. Mirrors the approach landed in thunder-id/javascript-sdks#24.

Approach

  • Added a vendor option to ThunderIDConfig (defaults to ThunderIDConfig.DEFAULT_VENDOR, "thunderid").
  • EncryptedStorageAdapter now accepts a prefsName override so callers can derive the EncryptedSharedPreferences file name from config.vendor.
  • ThunderIDProvider (Compose) now resolves the i18n locale storage key from config.vendor when no explicit ThunderIDI18n is supplied.
  • Replaced a brand-specific "ThunderID:SignIn" log tag with a generic "SignInFlow" tag, since the brand prefix wasn't load-bearing there.
  • Added vendor-naming guidance to AGENTS.md so future changes keep runtime keys/names vendor-aware.

Related Issues

Checklist

  • ./gradlew compileDebugKotlin passes.
  • ./gradlew ktlintCheck passes with 0 violations.

Adds a `vendor` option to ThunderIDConfig so adopters can white-label
the SDK's runtime identifiers (EncryptedSharedPreferences file name,
Compose i18n locale storage key) instead of being pinned to the
`thunderid` brand prefix. Also drops a brand-specific log tag in favor
of a generic one.

Related: thunder-id/thunderid#3896
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@brionmario, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0879aa07-499c-4bb2-b12d-f3e1653ce5b2

📥 Commits

Reviewing files that changed from the base of the PR and between 9d5ceb5 and 35dab31.

📒 Files selected for processing (6)
  • .coderabbit.yaml
  • AGENTS.md
  • src/main/kotlin/dev/thunderid/android/StorageAdapter.kt
  • src/main/kotlin/dev/thunderid/android/ThunderIDConfig.kt
  • src/main/kotlin/dev/thunderid/compose/ThunderIDProvider.kt
  • src/main/kotlin/dev/thunderid/compose/components/presentation/auth/SignIn.kt
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant