Documentation & Installation changes + Preshower Correction - #2
Open
maxgalli wants to merge 40 commits into
Open
Documentation & Installation changes + Preshower Correction#2maxgalli wants to merge 40 commits into
maxgalli wants to merge 40 commits into
Conversation
…ll python package quantile_regression_chain
…be able to save the output automatically in a log file
…ance reasons $ time python use_uproot.py real 1m8.391s user 2m32.585s sys 1m5.201s $ time python use_rootpandas.py real 5m51.522s user 5m29.781s sys 0m25.242s Conflicts: quantile_regression_chain/quantileRegression_chain.py setup.py
… also an absolute path (relative still allowed) Refactor stuff for better reading Conflicts: quantile_regression_chain/quantileRegression_chain.py
… Preshower-Systematics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since there are chances that neither of us will still be in the loop when this will have to be run once again for Run 3 data, I took the liberty of making some (I hope) useful changes in terms of installation/structure and documentation.
This should help the next poor soul that has to run them to go smoothly through the whole process by him/herself, without the need of asking us (as I said above, I think we should tackle the worst case scenario in which at that time we won't be in the loop anymore).
As you can see there are plenty of commits, but the actual changes are very few and none of them affects the internal behavior.
They can be mostly summarized in what follows:
python setup.py installand makes it possible to import the package from every location, without the need to update the PYTHONPATH;utils);N.B.: I kept the old code under the
legacyfolder; it can of course still be run with the changes I made, but the imports have to be changed (and also the name of thesetupJoblibfunction, see 76a2ed9)Update 13/05/2021: a new section (with documentation) was added for the preshower correction.