NAT, Docker, wildcard dialplan, μ-law perf, RTP playback pipeline - #44
Merged
Conversation
Add external-ip and nat-address flags for NAT traversal, Dockerfile and
compose for containerized deployment, and wildcard ("*") dialplan
entries for catch-all routing. Trunks now support per-trunk local_ip
override for multi-interface setups.
Replace per-sample encoding with a pre-computed [65536]byte lookup table for O(1) μ-law conversion. Also adds Docker Compose targets and skips NAT tests when not in Docker.
Use a producer-consumer pattern to marshal RTP packets ahead of the sender and send them on a ticker, reducing jitter and drift. The first packet is sent immediately, and subsequent packets are paced by a ticker for more accurate timing. Add TestRunFilePlayback_Timing to verify that per-packet jitter and total drift remain within acceptable bounds.
Per-packet jitter: <30ms (industry standard, VoIP <30ms per Cisco/IBM/ITU-T) Total drift: <50ms (allows for CI scheduler noise, still catches real regressions like the double-pacing bug)
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--nat-addressflag replaces loopback in SDP for Docker,resolveClientAddrusesnet.ResolveUDPAddrat all 6 call sites, Docker Compose with front/back trecsd instances"number": "*"match-all routestime.Ticker(fixed double-pacing bug), then producer-consumer pipeline for memory-bounded O(window) playbackcloses #43