Skip to content

fix: use paths_released and version outputs for immutable releases#19

Merged
thoroc merged 2 commits into
mainfrom
fix/release-please-outputs
Feb 6, 2026
Merged

fix: use paths_released and version outputs for immutable releases#19
thoroc merged 2 commits into
mainfrom
fix/release-please-outputs

Conversation

@thoroc

@thoroc thoroc commented Feb 6, 2026

Copy link
Copy Markdown
Owner

Problem\nWhen using skip-github-release: true to prevent release-please from creating the release (needed for immutability), the release_created output is never set to true. This caused the build_and_upload and create_release jobs to be skipped, resulting in releases without binaries.\n\n## Solution\nUse the correct outputs when skip-github-release: true:\n- paths_released - indicates a release should happen (set to ["."] for root releases)\n- version - the version number to construct the tag (e.g., v0.4.5)\n\n## Changes\n- Changed condition from release_created == 'true' to paths_released != '[]'\n- Changed tag_name from output to constructed: v${{ version }}\n\nThis ensures the workflow runs when a release is needed and creates the release atomically with all built binaries.

@thoroc
thoroc force-pushed the fix/release-please-outputs branch from 42a399f to 8b7d330 Compare February 6, 2026 23:28

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-copilot Please review this PR focusing on:

  1. Code quality, best practices, and potential bugs
  2. Security vulnerabilities and unsafe patterns
  3. Performance implications
  4. Documentation accuracy and completeness
  5. Test coverage and edge cases

Please provide specific, actionable feedback.

@thoroc
thoroc merged commit c119026 into main Feb 6, 2026
9 checks passed
@thoroc
thoroc deleted the fix/release-please-outputs branch February 6, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant