[pull] develop from frappe:develop#388
Merged
Merged
Conversation
- Reverted from frappe.db.set_value to frappe.qb.update (matching original mechanism) to avoid behavioral differences in how submitted attendance records are handled by other code paths. - Removed per-record doc-level permission check (frappe.has_permission with doc= argument) which fails for docstatus=1 documents in Frappe. Kept doctype-level permission check. - Moved all frappe.set_user() calls inside try/finally blocks to prevent test pollution when assertions fail. - Removed Scenario 3 (batch partial-write mock test) as it tested per-record checks that are no longer performed. - Kept batch-fetch optimization (frappe.get_list) and scoped qb.update to exact attendance name instead of employee+date.
…atus-closed fix: implement close warning for job openings and related validation.
fix: sync translations from crowdin
chore: update POT file
…ission fix: add permission check for half-day attendance updates
fix(pwa): resolve blank employee number and reports_to in Profile
…fault_options fix(pwa-link): Link field clears when selected value is outside default options page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )