fix(skills): guard skill cache with RWMutex for parallel tool calls (#53)#54
Merged
Merged
Conversation
Parallel skill tool calls could crash the process with concurrent map writes. Bump version to 0.8.1. Fixes #53 Co-authored-by: Cursor <cursoragent@cursor.com>
Version Check Results✅ Version format is valid: The VERSION file has been updated. Please ensure this matches the intended release version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync.RWMutexaround all reads/writes of the skills plugin cache so parallel tool calls no longer crash withfatal error: concurrent map writesTestGetSkill_ConcurrentNoRace) verified with-raceCHANGELOG.mdFixes #53
Test plan
go test -race ./src/plugins/skills/...main, then tagv0.8.1to trigger release workflowMade with Cursor