Skip to content

fix: improve onChange callback performance - #7

Open
haivle wants to merge 1 commit into
thinhkhang97:masterfrom
haivle:fix-bugs
Open

fix: improve onChange callback performance#7
haivle wants to merge 1 commit into
thinhkhang97:masterfrom
haivle:fix-bugs

Conversation

@haivle

@haivle haivle commented Apr 17, 2024

Copy link
Copy Markdown
  • Only call onChange callback when inViewport value changed
  • Fix the issue with incorrect measures on Android
  • Add onChange to useEffect dependency to allow the callback function to update its scope

Example

const [count, setCount] = useState(1);

useEffect(() => {
   setCount(2)
},[])

const handleViewPortChange = (isInViewport: boolean) => {
    console.log(count) // --> issue: always return 1
}

<ViewPortDetector onChange={handleViewPortChange}>
  {//...children}
</ViewPortDetector>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant