Rename EdgeStyle widget property to EdgeStyleValue - #24
Open
mvonhasselbach wants to merge 7 commits into
Open
Conversation
Rename EdgeStyle widget property so that it doesn't get picked up by the SolutionCentral packaging dependency resolution as a Style Entity
Rename EdgeStyle widget property
Removed example image links
incremented extension version number
stefan-lacatus
left a comment
stefan-lacatus
left a comment
Collaborator
There was a problem hiding this comment.
I'm a bit hesitant to merge this since it would break backwards compatibility of existing mashups.
Is there an existing ticket with Thingworx R&D to get this fixed in the correct place?
If a client is impacted, let me know, and I'll merge.
Author
|
Hi Petrisor, I agree - I thought about the backward compatibility breaking as well. My change is in fact for a customer - they brought it up when they tried to package an app that uses this widget with SolutionCentral. From my PoV we can also keep it as is and don't merge. I provided the new extension to the customer and pointed them to my fork for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename EdgeStyle widget property so that it doesn't get picked up by the SolutionCentral packaging dependency resolution as a Style Entity. See issue #23 . @stefan-lacatus and/or @BogdanMihaiciuc : can you check and approve my changes?