Skip to content

match for colors without hash - #1

Open
sewnie wants to merge 1 commit into
thimc:mainfrom
sewnie:main
Open

sewnie wants to merge 1 commit into
thimc:mainfrom
sewnie:main

Conversation

@sewnie

@sewnie sewnie commented Apr 8, 2024

Copy link
Copy Markdown

Allows the ability for colors such as cc241d to be detected, since some configuration formats such as 0xcc241d or cc241d alone do not get detected.

Allows the ability for colors such as cc241d to be detected, since some configuration formats such as 0xcc241d or cc241d alone do not get detected.
@thimc

thimc commented Apr 9, 2024 •

Copy link
Copy Markdown
Owner

Hi, thanks for taking an interest in the plugin.

The only issue I see with this commit is that if we allow the plugin to highlight any arbitrary hexadecimal text it may end up looking a bit weird when color highlighting isn't perhaps something we want or expect, so my thoughts are that perhaps we should be able to toggle this functionality? I was thinking that adding an additional variable that alters the plugins behaviour might be more ideal.

Let me know what you think.

@sewnie

sewnie commented Apr 9, 2024

Copy link
Copy Markdown
Author

While you are correct, some words will be mistaken for colors (like BADDAF probably), I prefer this behavior since it is I want to see colors.

I believe what could work is for the pattern to detect values such as 0xEBBDB2 and = EBDDB2 for configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants