Repository navigation
Conversation
Allows the ability for colors such as cc241d to be detected, since some configuration formats such as 0xcc241d or cc241d alone do not get detected.
Owner
|
Hi, thanks for taking an interest in the plugin. The only issue I see with this commit is that if we allow the plugin to highlight any arbitrary hexadecimal text it may end up looking a bit weird when color highlighting isn't perhaps something we want or expect, so my thoughts are that perhaps we should be able to toggle this functionality? I was thinking that adding an additional variable that alters the plugins behaviour might be more ideal. Let me know what you think. |
Author
|
While you are correct, some words will be mistaken for colors (like BADDAF probably), I prefer this behavior since it is I want to see colors. I believe what could work is for the pattern to detect values such as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the ability for colors such as cc241d to be detected, since some configuration formats such as 0xcc241d or cc241d alone do not get detected.