fix(ui): THI-346 — dropdown menu avatar, scrollbar redondante (suppression cap 440px)#373
Merged
Merged
Conversation
THI-341's anti-clip fix used max-h-[min(440px,calc(100dvh-200px))]. For a super_admin the menu is ~454px (header + 8 items at py-3), just above the 440px cap → a redundant scrollbar appeared on EVERY viewport and doubled the sidebar modules scrollbar (visual bug reported by @Thierry). Drop the fixed 440px cap → max-h-[calc(100dvh-200px)] alone: the dropdown takes its natural height and only scrolls when it genuinely can't fit (short screens), preserving the anti-clip safety net. Voie A (super_admin, 8 items): no scroll at 1280×800 / 768×1024 / 390×844, safety scroll without clipping at 1280×600. auth.test 16/16 unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @thierryvm, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THI-346 — Scroll du dropdown menu avatar (follow-up THI-341)
Bug @Thierry (2× signalé) : le dropdown du menu avatar affichait une scrollbar qui double celle de la sidebar Modules → visuellement cassé.
Cause : le fix anti-clip F-02 de THI-341 utilisait
max-h-[min(440px,calc(100dvh-200px))]. Pour un super_admin, le menu fait ~454px (header + 8 items àpy-3), juste au-dessus du cap 440px → scrollbar systématique sur tous les viewports (les rôles avec moins d'items ne scrollaient pas).Fix (1 ligne, 2 dropdowns) : retirer le cap fixe
440px→max-h-[calc(100dvh-200px)]. Le dropdown prend sa taille naturelle et ne scrolle que quand il ne tient vraiment pas (écrans courts), tout en gardant le filet anti-clip.Voie A empirique (super_admin, 8 items)
Screenshot desktop :
.tmp/thi346-dropdown-desktop.png(8 items, 0 scrollbar interne).type-check+lintclean,auth.test16/16 (UserMenu, inchangés). Gatemobile-responsive-auditoren cours.🤖 Generated with Claude Code