Repository navigation
feat(ui): pass-through des attributs sur Ui:Button (v1.6.2) - #42
Merged
Merged
Conversation
Rend `attributes.defaults({class: baseClasses})` sur les branches <a> et <button> :
les attributs HTML non-props (data-action, data-*-target, id, aria-*) sont relayés
et un `class` fourni est fusionné avec les classes du socle (focus visible WCAG 2.4.7
préservé). Débloque la migration des boutons câblés Stimulus vers le composant.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Pp2ANkdPP9LG5BdqoDSyNf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexte
Le composant
tsf:Ui:Buttonne relayait pas les attributs HTML non-props :<twig:tsf:Ui:Button data-action="…">perdait l'attribut. Les applications consommatrices ne pouvaient donc pas migrer leurs boutons câblés Stimulus vers le composant (focus a11y ajouté « en direct »).Changement
attributes.defaults({class: baseClasses})sur les deux branches (<a>et<button>).data-action,data-*-target,id,aria-*) sont relayés.classfourni par l'appelant est fusionné avec les classes du socle (focus visible WCAG 2.4.7 préservé).Validation
🤖 Generated with Claude Code
https://claude.ai/code/session_01Pp2ANkdPP9LG5BdqoDSyNf