ASoC: soc-acpi-intel-matchs: use function topology by default #5797
Open
bardliao wants to merge 6 commits into
Open
ASoC: soc-acpi-intel-matchs: use function topology by default #5797bardliao wants to merge 6 commits into
bardliao wants to merge 6 commits into
Conversation
bardliao
requested review from
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
Collaborator
Author
|
@macchian Please double check which audio configurations are for Google projects and cannot use the function topology. |
There was a problem hiding this comment.
Pull request overview
This PR updates Intel ASoC SoundWire ACPI machine match tables to prefer “function topology” selection by default via the .get_function_tplg_files callback, allowing a fallback to monolithic topology when required function topology files are missing.
Changes:
- Add
.get_function_tplg_files = sof_sdw_get_tplg_filesto multiplesnd_soc_acpi_machentries for PTL/MTL/LNL/ARL SoundWire machines. - Extend function-topology defaulting to additional platform configurations (notably RVP entries).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| sound/soc/intel/common/soc-acpi-intel-ptl-match.c | Adds function-topology callback for a PTL SoundWire machine entry. |
| sound/soc/intel/common/soc-acpi-intel-mtl-match.c | Adds function-topology callback to multiple MTL SoundWire machine entries (one initializer currently has a syntax issue). |
| sound/soc/intel/common/soc-acpi-intel-lnl-match.c | Adds function-topology callback to multiple LNL SoundWire machine entries (currently includes syntax and duplicate-initializer issues). |
| sound/soc/intel/common/soc-acpi-intel-arl-match.c | Adds function-topology callback to additional ARL SoundWire machine entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bardliao
force-pushed
the
use-function-topology
branch
from
e41a7da to
c827969
Compare
bardliao
force-pushed
the
use-function-topology
branch
from
c827969 to
f000bb3
Compare
macchian
reviewed
Jun 2, 2026
| .link_mask = BIT(0) | BIT(2) | BIT(3), | ||
| .links = ptl_rt722_l0_rt1320_l23, | ||
| .drv_name = "sof_sdw", | ||
| .sof_tplg_filename = "sof-ptl-rt722-l0-rt1320-l23.tplg", |
There was a problem hiding this comment.
We need this for Chrome and Android SKU.
.machine_check = snd_soc_acpi_intel_no_function_topology,
macchian
reviewed
Jun 2, 2026
There was a problem hiding this comment.
We need this for Chrome and Android SKU.
.machine_check = snd_soc_acpi_intel_no_function_topology,
machine check function This check function return snd_soc_acpi_intel_sdca_is_device_rt712_vb() && snd_soc_acpi_intel_no_function_topology() for the cases that need check is the device is rt712 vb and no function topology. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
function topology There are still some Google machines that need to use the monolithic topology. Add the machine check for those machines. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
With commit c84179a ("ASoC: Intel: sof_sdw: append dai type to dai link name unconditionally"), function topology can apply to all SoundWire codec configurations. Set .get_function_tplg_files callback to use function topology by default. If any required function topology can not be found in the file system, it will fallback to use the monolithic topology. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
With commit c84179a ("ASoC: Intel: sof_sdw: append dai type to dai link name unconditionally"), function topology can apply to all SoundWire codec configurations. Set .get_function_tplg_files callback to use function topology by default. If any required function topology can not be found in the file system, it will fallback to use the monolithic topology. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
With commit c84179a ("ASoC: Intel: sof_sdw: append dai type to dai link name unconditionally"), function topology can apply to all SoundWire codec configurations. Set .get_function_tplg_files callback to use function topology by default. If any required function topology can not be found in the file system, it will fallback to use the monolithic topology. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
With commit c84179a ("ASoC: Intel: sof_sdw: append dai type to dai link name unconditionally"), function topology can apply to all SoundWire codec configurations. Set .get_function_tplg_files callback to use function topology by default. If any required function topology can not be found in the file system, it will fallback to use the monolithic topology. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
force-pushed
the
use-function-topology
branch
from
f000bb3 to
77554ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With commit c84179a ("ASoC: Intel: sof_sdw: append dai type to dai
link name unconditionally"), function topology can apply to all
SoundWire codec configurations. Set .get_function_tplg_files callback to
use function topology by default. If any required function topology can
not be found in the file system, it will fallback to use the monolithic
topology.