fix: hold assigned port at start-up until Pg start command exec#252
Open
tzemanovic wants to merge 1 commit into
Open
fix: hold assigned port at start-up until Pg start command exec#252tzemanovic wants to merge 1 commit into
tzemanovic wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for this crate! I'm using multiple embedded DBs concurrently with auto-assigned ports and it seems that there is a race condition in the start-up as randomly they fail to start. I found that the assigned port at start-up is not held open before the
pg_ctlcommand uses it again, so another process may try re-use it in the meantime.This fix instead tries to assign a random port directly for the
pg_ctlcommand and retry 3 times on port conflict