Add dashboard error boundaries#7
Open
Florcitaq wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1
Summary
Adds reusable React error boundaries around the dashboard and major layout sections so render-time failures in one section do not take down the whole UI.
Changes
ErrorBoundaryas a reusable class component usinggetDerivedStateFromErrorandcomponentDidCatch.Header,Sidebar, and main route content in separate layout-level boundaries.StatCardcomponent and wrapped the stat grid in a distinct boundary.Testing
npm installnpm run buildPYTHONUTF8=1 python -u build.py -m frontend --verboseValidation passed for the affected frontend module.
Diagnostic artifacts generated by
build.pyfor commit0dde0a5:diagnostic/build-0dde0a52.jsondiagnostic/build-0dde0a52-part001.logddiagnostic/build-0dde0a52-part002.logddiagnostic/build-0dde0a52-part003.logddiagnostic/build-0dde0a52-part004.logddiagnostic/build-0dde0a52-part005.logddiagnostic/build-0dde0a52-part006.logdDiagnostic password:
Note: on this Windows environment, Python
subprocesscould not launchnpmunless the build command usednpm.cmd. I used that as a local validation workaround and did not include it in the frontend patch.Checklist