move functions to traits to allow any version of phpunit - #15
Open
gabrielsolomon wants to merge 2 commits into
Open
move functions to traits to allow any version of phpunit#15gabrielsolomon wants to merge 2 commits into
gabrielsolomon wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By splitting the functionality in traits you can write test by importing only needed traits and not depending on a base omnipay test.
Also moving the phpunit to require-dev the package is decoupled from the phpunit.
This way the developer can use which version he choses and only imports the traits where he needs them. He can also chose to import them in his one base test if he chose so