Skip to content

Remove @doesNotPerformAssertions annotations - #279

Merged
barryvdh merged 1 commit into
thephpleague:masterfrom
Chris53897:patch-2
Dec 3, 2025
Merged

Remove @doesNotPerformAssertions annotations#279
barryvdh merged 1 commit into
thephpleague:masterfrom
Chris53897:patch-2

Conversation

@Chris53897

@Chris53897 Chris53897 commented Nov 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Removed unnecessary annotations from test methods.

Remove the warnings in the ci

There were 2 risky tests:

1) Omnipay\Common\HelperTest::testInitializeCallsSetters
This test is annotated with "@doesNotPerformAssertions" but performed 2 assertions

phpvfscomposer:///home/runner/work/omnipay-common/omnipay-common/vendor/phpunit/phpunit/phpunit:97

2) Omnipay\Common\HelperTest::testInitializeIgnoresInvalidParameters
This test is annotated with "@doesNotPerformAssertions" but performed 1 assertions

@Chris53897
Remove @doesNotPerformAssertions annotations
5b373f7 
Removed unnecessary annotations from test methods.
@barryvdh
barryvdh merged commit 3d5042c into thephpleague:master Dec 3, 2025
9 checks passed
@Chris53897
Chris53897 deleted the patch-2 branch December 3, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Chris53897 @barryvdh