Skip to content

Fix oauth2-client 3 compat, drop PHP 7 support#142

Merged
shadowhand merged 2 commits into
thephpleague:mainfrom
garak:fix-getid
Mar 23, 2026
Merged

Fix oauth2-client 3 compat, drop PHP 7 support#142
shadowhand merged 2 commits into
thephpleague:mainfrom
garak:fix-getid

Conversation

@garak

@garak garak commented Mar 22, 2026

Copy link
Copy Markdown
Contributor

Fix #141

Copilot AI review requested due to automatic review settings March 22, 2026 10:33
@codecov

codecov Bot commented Mar 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (72be695) to head (b571b73).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #142   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        40        40           
===========================================
  Files              3         3           
  Lines             82        82           
===========================================
  Hits              82        82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the library to align with league/oauth2-client v3’s ResourceOwnerInterface expectations and formally drops PHP 7 support across packaging, docs, and CI.

Changes:

  • Update GoogleUser::getId() signature to return mixed for oauth2-client v3 compatibility.
  • Drop PHP 7 support (Composer constraint, docs, and CI matrix).
  • Document the upcoming release changes in the changelog.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Provider/GoogleUser.php Adds : mixed return type to getId() for oauth2-client v3 interface compatibility.
composer.json Raises minimum PHP requirement to ^8.0.
README.md Updates supported PHP versions list and notes where PHP 7 support can be found.
CHANGELOG.md Adds unreleased notes for oauth2-client v3 compatibility + PHP 7 removal.
.github/workflows/ci.yml Removes PHP 7 from CI and adds newer PHP versions to the test matrix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml

@shadowhand shadowhand left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small changes, then good to go.

Comment thread .github/workflows/ci.yml Outdated
Comment thread CHANGELOG.md
@shadowhand
shadowhand merged commit d3e3f4b into thephpleague:main Mar 23, 2026
11 checks passed
@garak
garak deleted the fix-getid branch March 23, 2026 14:25
@shadowhand

Copy link
Copy Markdown
Member

Released in version 5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getId method in GoogleUser should return mixed

3 participants