Skip to content

use explicit error types for public api #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theodore-s-beers merged 2 commits into from
May 12, 2026
Merged

use explicit error types for public api #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d04b9e1
use explicit error types for public api
theodore-s-beers May 12, 2026
796d169
add oxfmt config
theodore-s-beers May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .oxfmtrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{ "ignorePatterns": [] }
9 changes: 6 additions & 3 deletions src/collator.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ const types = @import("types");
const util = @import("util");

pub const Collator = struct {
pub const InitError = error{OutOfMemory};
pub const CollateError = error{OutOfMemory};

alloc: std.mem.Allocator,

table: types.CollationTable = .cldr,
Expand Down Expand Up @@ -41,7 +44,7 @@ pub const Collator = struct {
table: types.CollationTable,
shifting: bool,
tiebreak: bool,
) !Collator {
) InitError!Collator {
const low_table: [183]u32 = if (table == .cldr) consts.LOW_CLDR else consts.LOW;

var coll = Collator{
Expand Down Expand Up @@ -78,7 +81,7 @@ pub const Collator = struct {
return coll;
}

pub fn initDefault(alloc: std.mem.Allocator) !Collator {
pub fn initDefault(alloc: std.mem.Allocator) InitError!Collator {
return try Collator.init(alloc, .cldr, true, true);
}

Expand All @@ -99,7 +102,7 @@ pub const Collator = struct {
// Collation
//

pub fn collate(self: *Collator, a: []const u8, b: []const u8) !std.math.Order {
pub fn collate(self: *Collator, a: []const u8, b: []const u8) CollateError!std.math.Order {
if (std.mem.eql(u8, a, b)) return .eq;

// Decode function clears input list
Expand Down
Loading