Fix CI (green for the first time): lockfile + lint/format + deploy job#3
Merged
Conversation
Pre-existing CI failures, now fixed: - backend: `uv sync` only installed the root project, so ruff/pytest were missing -> add --all-packages --all-groups; pin uv to 0.11.* (matches the committed lock format). - ruff: clear ~14 lint findings (UP017/E501/SIM105...) and apply ruff format across the repo (whitespace-only; logic unchanged). - frontend: regenerate package-lock.json so `npm ci` is in sync with package.json (esbuild drift). - drop the Fly.io deploy job (no longer deploying there). Verified locally: ruff check + format clean, 206 backend tests pass, frontend typecheck + 151 vitest tests + build all pass.
The node-26/npm-11 lockfile listed platform-specific esbuild binaries in a way npm 10 (CI's node 20) rejected with EBADPLATFORM. Regenerated under node 20 so `npm ci` resolves cleanly. Verified: npm ci + typecheck + 151 vitest + build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-existing red CI, now fixed. Backend uv sync now installs workspace dev groups; ruff lint+format cleaned; frontend package-lock regenerated; Fly deploy job removed. Verified locally (206 backend + 151 frontend tests, build OK).