Repository navigation
Conversation
Lost Password is the primary reset flow; listing a unset legacy Reset Password page as Not Setup was misleading in support reports. Co-authored-by: Cursor <cursoragent@cursor.com>
QA suite — refused, no regression specThis PR changes product source but adds no spec, so the suite was Source files changed with no matching spec |
PHPCS results✅ No PHPCS issues found. |
Contributor
Author
|
Closing — release bug: push directly to v5.3.0 (no PR). |
There was a problem hiding this comment.
🟢 Approval recommended
The scoped functional change is complete; the remaining documentation note is minor.
0 open findings
What changed in this PR
Updates System Info so the legacy Reset Password page is shown only when configured.
Changes:
- Removes unconfigured Reset Password from required pages.
- Preserves reporting for legacy configurations.
| File | Description |
|---|---|
includes/admin/views/html-admin-page-system-info.php |
Conditionally reports the legacy Reset Password page. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
y000yal
deleted the
UR-1903-fix/system-info-reset-password-not-required
branch
October 9, 2026 07:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
System Info → Required Pages listed Reset Password Page as Not Setup even when Lost Password was Live. Reset Password is a legacy/optional page; Lost Password is the primary reset flow (
ur_resetpassword_url).Closes themegrill/user-registration-pro#1903.
How to test the changes in this Pull Request:
user_registration_reset_password_page_idempty (default).Types of changes:
Other information:
Changelog entry
Made with Cursor