Skip to content

#1903 Fix - Drop unconfigured Reset Password from System Info required pages - #1549

Closed
y000yal wants to merge 1 commit into
v5.3.0from
UR-1903-fix/system-info-reset-password-not-required
Closed

y000yal wants to merge 1 commit into
v5.3.0from
UR-1903-fix/system-info-reset-password-not-required

Conversation

@y000yal

@y000yal y000yal commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

All Submissions:

Changes proposed in this Pull Request:

System Info → Required Pages listed Reset Password Page as Not Setup even when Lost Password was Live. Reset Password is a legacy/optional page; Lost Password is the primary reset flow (ur_resetpassword_url).

  • Stop treating unset Reset Password as a required page
  • Still list it when the option is configured (legacy installs)

Closes themegrill/user-registration-pro#1903.

How to test the changes in this Pull Request:

  1. Ensure Lost Password page is set and published; leave user_registration_reset_password_page_id empty (default).
  2. Open Settings → Tools → System Info → Required Pages.
  3. Confirm Reset Password Page is not listed / no Not Setup for it; Lost Password still shows Live.
  4. (Optional) Set a Reset Password page ID → row should appear again with Live/Not Setup based on that page.

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Changelog entry

Fix - Do not list an unconfigured Reset Password page as required in System Info.

Made with Cursor

Lost Password is the primary reset flow; listing a unset legacy Reset Password page as Not Setup was misleading in support reports.

Co-authored-by: Cursor <cursoragent@cursor.com>
@y000yal y000yal self-assigned this Oct 9, 2026
@tg-autopilot
tg-autopilot requested a lite review from Copilot October 9, 2026 07:10
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

QA suite — refused, no regression spec

This PR changes product source but adds no spec, so the suite was
refused before booting WordPress — running it just to report the same
thing at the end costs runner minutes for nothing. Run
/claudegrill:verify-fix locally and let write-spec add the guard
to this branch, then push again.

Source files changed with no matching spec
includes/admin/views/html-admin-page-system-info.php

@y000yal
y000yal requested a review from bhattaganesh October 9, 2026 07:10
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

PHPCS results

✅ No PHPCS issues found.

@y000yal

y000yal commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

Closing — release bug: push directly to v5.3.0 (no PR).

@y000yal y000yal closed this Oct 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The scoped functional change is complete; the remaining documentation note is minor.

0 open findings

What changed in this PR

Updates System Info so the legacy Reset Password page is shown only when configured.

Changes:

  • Removes unconfigured Reset Password from required pages.
  • Preserves reporting for legacy configurations.
File Description
includes/​admin/​views/​html-admin-page-system-info.php Conditionally reports the legacy Reset Password page.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@y000yal
y000yal deleted the UR-1903-fix/system-info-reset-password-not-required branch October 9, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants