Skip to content

fix: validate host_url to prevent Host-header injection XSS #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Joshua-Medvinsky wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: validate host_url to prevent Host-header injection XSS #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion python_a2a/server/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import re
"""
HTTP server implementation for the A2A protocol.
"""
Expand Down Expand Up @@ -108,10 +109,14 @@ def enhanced_a2a_index():
})

# Otherwise serve HTML by default
# Validate host_url to prevent Host-header injection
host_url = request.host_url
if not re.match(r'^https?://[a-zA-Z0-9._-]+(:\d+)?/', host_url):
host_url = request.scheme + "://" + request.host.split(":")[0]
response = make_response(render_template_string(
AGENT_INDEX_HTML,
agent=agent,
request=request
host_url=host_url
))
response.headers['Content-Type'] = 'text/html; charset=utf-8'
return response
Expand Down