fix: Remove eval() from workflow condition evaluation#88
Closed
Joshua-Medvinsky wants to merge 1 commit into
Closed
fix: Remove eval() from workflow condition evaluation#88Joshua-Medvinsky wants to merge 1 commit into
Joshua-Medvinsky wants to merge 1 commit into
Conversation
Replaces dangerous eval() call in workflow condition handling with explicit callable requirement. Fixes: Code Injection in python_a2a/workflow.py:47
Author
|
Closing — duplicate of #89 which was submitted moments later with the same fix. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eval()call used to evaluate workflow condition stringslambda) instead of a raw expression stringVulnerability
python_a2a/workflow.pyevaluated theconditionparameter with Python'seval()if it was not callable:An attacker who controls the
conditionargument (e.g. via a serialised workflow definition or API call) can pass any Python expression — including__import__('os').system('...')— resulting in arbitrary code execution with the privileges of the server process.Severity: Critical
CWE: CWE-94 (Code Injection)
Fix
Callers that previously passed strings must migrate to lambdas:
Test plan
ValueErroris raised when a string condition is passed