Give each test its own temporary directory#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem & Solution Overview
The unit and integration tests shared fixed output directories under the repo (
.test-output,.test-output-*,.integration-output), so two concurrent runs (e.g.npm testalongsidenpm run test:coverage) could delete each other's files mid-test. Each test now creates a unique directory under the OS temp dir inbeforeEach(fs.mkdtempSync) and removes only its own directory inafterEach.Testing Done
npm test: 203 passing.npm testandnpm run test:coveragerun concurrently with both passing (exit 0, 203 each). No shared output directories remain under the repo.