Percepciones1_0: soportar sac:ExceptionalIndicator (campo 7) - #274
Merged
Conversation
Member
|
Agregaré primero ese nuevo tag ExceptionalIndicator a ubl-validator |
Member
|
Ya fue incluido, volviendo a instalar los paquetes deberia traer la ultima version, y deberia permitir agregar los tests de schema en Percepcion |
… y validar campo (#275) - Propiedad y accesores en español (`indExcepcional`), siguiendo la convención del modelo; el tag XML `sac:ExceptionalIndicator` no cambia. - Restricción `Length(2)` en `PerceptionLoader` con tests en `CePerceptionValidatorTest`. - Tests del builder integrados en `CePerceptionBuilderTest` con validación contra el XSD (`greenter/ubl-validator` ^2.3). - Entrada `Unreleased` en CHANGELOG. Claude-Session: https://claude.ai/code/session_012XxTfA813bR5kFXN5FCrii Co-authored-by: giansalex <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #274 +/- ##
=========================================
Coverage 95.86% 95.87%
- Complexity 1310 1312 +2
=========================================
Files 173 173
Lines 5470 5477 +7
=========================================
+ Hits 5244 5251 +7
Misses 226 226
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
giansalex
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No existía ese campo en greenter, se evita 3322