Repository navigation
feat(console): function and trigger dialogs (point 12.3, first part) - #223
Merged
Merged
Conversation
New, Edit, Rename and Drop for functions, procedures, trigger functions and triggers. Each dialog shows the SQL as it is built and runs it as the person. An edit keeps what it has no field for. The catalog gives each function's attributes and each trigger's parts, and marks trigger functions in the list. Also: a late reply about the branch just left no longer replaces the console's catalog of the branch switched to.
…e suites' counts, and the PDFs
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First part of point 12.3 (pgAdmin's basics): create and edit dialogs for functions, procedures, trigger functions and triggers. Table dialogs follow in a separate PR.
What it adds
routineandtriggerdetails onGET …/schema/{kind}/{oid}and marks trigger functions in the list.fox schemaoutput is unchanged.Fixed on the way
A slow reply about the branch just left could replace the Console's catalog of the branch switched to, and a table then said it was not in the catalog. Each load now ignores replies to an earlier one.
routines.spec.tscovers it by delaying the reply.Worth knowing
db_client), so one account can change a function another account made. This already held in the SQL editor and the dialogs do not widen it.Tests
On this branch, rebased on main after #222:
routines.spec.tsnew)Before the rebase, on the same feature code: