Fixes #39533 - "View task" disabled when job is running - #1044
Closed
MariaAga wants to merge 2 commits into
Closed
Conversation
kmalyjur
self-requested a review
July 21, 2026 10:27
kmalyjur
requested changes
Jul 21, 2026
Contributor
There was a problem hiding this comment.
Works as it should.
In webpack/JobInvocationDetail/__tests__/TemplateInvocation.test.js, lines 198-202 (permissions) are now unused and could be deleted.
In webpack/JobInvocationDetail/__tests__/fixtures.js, the export const mockPermissionsData seems to be unused, too.
MariaAga
force-pushed
the
view-task-perms
branch
from
July 22, 2026 09:51
16b772d to
045102f
Compare
Member
Author
|
Thanks! removed it, js tests are passing locally |
Contributor
|
@MariaAga Thank you. Additionally, I see that when I have a user with only one permission |
Member
Author
|
I cant reproduce this issue anymore so closing. Couldnt see anything that would have fixed it recently, so not sure if my env just had issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
include_permissionswasnt present in every api call when job is running, causing the view task button to be disabled as it didnt have permissions data.Also just removed the usage of
include_permissionsapi requests for permissions, as all permissions are loaded to the foreman metadata.