Remove deprecation warning for Puppet (CA) Proxy bulk action - #444
Merged
Conversation
Collaborator
Author
|
@adamruzicka Can you please have a look at this? |
Contributor
Yeah, let's have it.
Could you please file an issue for it? |
Collaborator
Author
Here is the issue: https://projects.theforeman.org/issues/39356 |
adamruzicka
approved these changes
May 26, 2026
Contributor
|
Thank you @nadjaheitmann ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have still endpoints in foreman core namespace although they have been implemented a long time ago in the foreman_puppet plugin. They were implemented to ease the transfer of extracting the Puppet feature to plugin. This is round about 5 years ago.
I suggest that we remove those endpoints for Foreman 5.0, means soon. I know that this proposal makes this PR somehow seeming unnecessary, but I'd vote to have it as a quick fix and then thoroughly look at the rest of the routes.