Use shared GitHub Action for Ruby tests - #133
Merged
Merged
Conversation
evgeni
commented
Jan 25, 2024
| if: github.event_name != 'push' | ||
| run: | | ||
| bundle exec rake test:foreman_leapp -v --trace | ||
| bundle exec rake test TEST="test/unit/foreman/access_permissions_test.rb" -v --trace |
29 tasks
evgeni
commented
Jan 25, 2024
we want to seed templates that include `provider_type: Ansible`
evgeni
commented
Jan 25, 2024
Comment on lines
+3
to
+4
| require 'foreman_ansible' | ||
| require 'foreman_remote_execution' |
Member
Author
There was a problem hiding this comment.
this fixes #120
(technically, I guess, foreman_ansible would be enough, but I felt like being explicit here)
ekohl
reviewed
Jan 25, 2024
ekohl
left a comment
ekohl
left a comment
Member
There was a problem hiding this comment.
I think the require statement is correct. I'm not sure how else it could be solved.
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
stejskalleos
approved these changes
Jan 25, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.