Fixes #39492 - Replace enzyme test in SettingsTable, SettingsCell, SettingsName with RTL - #11084
Open
kfamilonidis wants to merge 1 commit into
Open
Fixes #39492 - Replace enzyme test in SettingsTable, SettingsCell, SettingsName with RTL#11084kfamilonidis wants to merge 1 commit into
kfamilonidis wants to merge 1 commit into
Conversation
kfamilonidis
force-pushed
the
pf5-setttings-table
branch
from
July 2, 2026 13:53
e1f49e5 to
8f88452
Compare
Contributor
|
@kfamilonidis please add more testing cases |
kfamilonidis
force-pushed
the
pf5-setttings-table
branch
from
July 8, 2026 11:15
8f88452 to
c75b1ae
Compare
Contributor
Author
|
Added 4 more tests that check the settings table values (instead of row headers that was before) |
kfamilonidis
force-pushed
the
pf5-setttings-table
branch
3 times, most recently
from
July 8, 2026 13:42
5ff80b6 to
aabfb44
Compare
Contributor
SummaryGood migration across Critical (must fix before merge)
Suggestions (should fix)
Nice to have (optional)
Checklist gaps
|
kfamilonidis
force-pushed
the
pf5-setttings-table
branch
2 times, most recently
from
July 14, 2026 12:28
3b36353 to
a38df2e
Compare
Contributor
Author
|
@Lukshio Replaced mock store with a real redux store. |
…ttingsName with RTL
kfamilonidis
force-pushed
the
pf5-setttings-table
branch
from
July 14, 2026 14:09
a38df2e to
a0b5b6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39492: Replace enzyme test in SettingsTable, SettingsCell, SettingsName with RTL