Conversation
ekohl
reviewed
Jul 19, 2024
evgeni
force-pushed
the
debrepo
branch
3 times, most recently
from
August 28, 2024 12:45
3e6f3ee to
94de686
Compare
evgeni
commented
Aug 28, 2024
evgeni
commented
Aug 28, 2024
Merged
evgeni
commented
Aug 29, 2024
evgeni
force-pushed
the
debrepo
branch
2 times, most recently
from
August 29, 2024 08:50
f85e79a to
2d48ee7
Compare
evgeni
commented
Aug 29, 2024
evgeni
marked this pull request as ready for review
August 29, 2024 08:57
Member
Author
|
marked this as ready as it spins up a working el9-freight host for me and should not influence anything of the current web01 deployment. |
ekohl
reviewed
Aug 29, 2024
ekohl
reviewed
Aug 29, 2024
evgeni
force-pushed
the
debrepo
branch
2 times, most recently
from
August 30, 2024 08:27
cf82c92 to
ada7227
Compare
evgeni
commented
Aug 30, 2024
Comment on lines
+61
to
+66
| # vhosts don't autorequire the expires module | ||
| # https://github.com/puppetlabs/puppetlabs-apache/pull/2559 | ||
| # limit to not EL7 as there we use apache::default_mods | ||
| if $facts['os']['family'] != 'RedHat' or $facts['os']['release']['major'] != '7' { | ||
| include apache::mod::expires | ||
| } |
Member
Author
There was a problem hiding this comment.
Or we move that to
foreman-infra/puppet/data/osfamily/RedHat-9.yaml
Lines 2 to 3 in 78d1281
evgeni
force-pushed
the
debrepo
branch
2 times, most recently
from
September 3, 2024 10:31
bc4c662 to
f1d4e20
Compare
evgeni
commented
Sep 3, 2024
evgeni
force-pushed
the
debrepo
branch
2 times, most recently
from
September 5, 2024 07:22
4247699 to
17f21bf
Compare
evgeni
commented
Sep 10, 2024
Comment on lines
+67
to
+70
| include apache::mod::alias | ||
| include apache::mod::autoindex | ||
| include apache::mod::dir | ||
| include apache::mod::mime |
Member
Author
There was a problem hiding this comment.
I wonder if any of these should (or should not) go to our definition of apache::default_mods
Member
Author
ehelms
approved these changes
Sep 10, 2024
ehelms
left a comment
ehelms
left a comment
Member
There was a problem hiding this comment.
I'm good with this - let's do this.
the vhosts do not point to it yet, so LE won't be able to obtain a cert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.