Repository navigation
feat(storybook): add dashboard stories, MCP, and browser tests - #346
Open
alterdianne wants to merge 3 commits into
Open
alterdianne wants to merge 3 commits into
alterdianne wants to merge 3 commits into
Conversation
- Root Storybook (React/Vite) with docs, a11y, and theme addons, loading the dashboard token/style stack so components render as in the app - Button (apps/dashboard/components/Button.tsx) built from the Figma Button set: primary/secondary/ghost/destructive/link, sm/md, hover/pressed/ focus/disabled; renders <a> when given href, otherwise <button> - Autodocs page from TypeScript + JSDoc and a Usage page (MDX) with rules, variant guidance, and common mistakes Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
React 18 does not pass `ref` to function components as a prop, so the ref test failed in the react 18 CI job. Wrap Button in forwardRef and cover link refs too. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
alterdianne
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a root Storybook for developing and testing dashboard components, with MCP access for coding agents. Includes a documented, React 18-compatible Button component with five variants, two sizes, navigation links, disabled states, and forwarded refs.
http://localhost:6006/mcp, Chromium-backed Vitest tests, accessibility reporting, and the Chromatic addon. CI installs Chromium before running coverage.Validation: 2,779 tests passed (163 skipped) across unit and Storybook browser suites with
VITE_USE_MOCKSset to an empty value to override the local preview environment. Storybook and application type checks, the static Storybook build, and a Bun 1.4 frozen-lockfile install passed. Diff line and branch coverage againstorigin/trunkare both 100%. Storybook MCP tools were unavailable during this validation; browser stories ran through the local Vitest integration.Accessibility findings remain advisory (
test: 'todo'). The existing Button documentation records the destructive variant's light-theme contrast issue. Chromatic requires a separately connected project.