Repository navigation
fix(storybook): drop ./ prefix from bin path - #340
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Vercel previewCommit: |
PyPranav
approved these changes
Oct 21, 2026
PyPranav
left a comment
PyPranav
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the bin path normalization. Both paths normalize identically in npm, and all reported checks pass. No blocking issues found.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
./prefix from thebinentry inpackages/crrt-storybook/package.json(./dist/cli.js→dist/cli.js).Why
npm 11 normalizes the path at publish time anyway and emits a misleading warning:
The entry is not actually removed — npm just strips the prefix. Verified in
@npmcli/package-json/lib/normalize.js, and the live 0.1.0 package on npm has the bin intact ({ crrt-storybook: 'dist/cli.js' }).Cosmetic only — silences the warning in future CI publishes. Seen in https://github.com/thedesignproject/CRRT/actions/runs/38770591595