This repository was archived by the owner on May 3, 2021. It is now read-only.
- add: support config for the 6 params supported by Material-UI - #20
Open
kavimaluskam wants to merge 1 commit into
Open
- add: support config for the 6 params supported by Material-UI#20kavimaluskam wants to merge 1 commit into
kavimaluskam wants to merge 1 commit into
Conversation
…showCheckboxes, enableSelectAll, showRowHover, stripedRow) supported by Material-UI. (Testing missed)
Author
|
And thank you so much for your work @andela-cdaniel !!! |
|
this addition will be great! |
|
might want to consider that this line in the code <TableFooter if you set this as false and you have pagination as true, the pagination does not show |
Author
|
Yes. @cvaladez But as material-ui itself has similar situation, i just let it be the case. |
|
why not use This will adjust the footer only when you have pagination |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing file missed tho.
Fixed issue:
#17
#18