Skip to content

Blind review: production observability call sites #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thebtf wants to merge 1 commit into from
Closed

Blind review: production observability call sites #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions ...nt/reports/evidence/production-ready/observability/sol-synthesis-20260713-r1/summary.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"schema_version": 1,
"gate": "observability-otlp",
"started_at_utc": "2026-07-13T02:21:09.7732887+00:00",
"completed_at_utc": "2026-07-13T02:21:12.4795109+00:00",
"command": "go test ./internal/module/obs -count=1 -json",
"exit_code": 0,
"required_tests": [
"TestInitNoEndpointIsNoop",
"TestInitForService_ExportsDaemonResourceIdentity",
"TestOTLPExportsStableMetricsAndKeepsHeaderOutOfPayload",
"TestOTLPTLSWithExplicitTrustRoot",
"TestCollectorAuthFailureIsBoundedAndSecretFree",
"TestCollectorBackpressureHonorsDeadline",
"TestTransientCollectorFailureRetriesWithinCallerDeadline",
"TestExporterOutageAndTLSMismatchAreBounded",
"TestShutdownFlushesPendingMetric",
"TestEndpointCredentialsAreRejectedWithoutEcho",
"TestConcurrentInitRecordShutdown",
"TestRuntimeOwnershipIsIdempotentAndReinitializable",
"TestRepeatedLifecycleWhileRecording"
],
"missing_tests": [],
"failed_tests": [],
"process_residue": [],
"container_residue": [],
"verdict": "PASS"
Comment on lines +23 to +27

@coderabbitai coderabbitai Bot Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift

Не заявляйте отсутствие residue без фактической проверки.

process_residue и container_residue всегда записываются как пустые массивы в scripts/production-smoke/verify-otlp.ps1, а verdict не учитывает утечки процессов или контейнеров. Поэтому этот PASS-артефакт может пройти при оставшемся exporter/collector residue. Добавьте реальную проверку либо удалите эти поля из evidence-контракта.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
@.agent/reports/evidence/production-ready/observability/sol-synthesis-20260713-r1/summary.json
around lines 23 - 27, Update the evidence generation in verify-otlp.ps1 so
process_residue and container_residue are populated from actual process and
container checks rather than hard-coded empty arrays, and make verdict fail when
either contains residue. If these checks cannot be implemented, remove both
fields from the evidence contract and stop claiming their absence.

}
43 changes: 43 additions & 0 deletions ...es-foundation/critical-suite-runner/sol-synthesis-20260713-observability-r2/commands.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
[
{
"name": "critical-go-test",
"executable": "C:\\Program Files\\Go\\bin\\go.exe",
"arguments": [
"test",
"-tags=critical",
"-json",
"./tests/critical/...",
"-count=1"
],
"command": "\"C:\\Program Files\\Go\\bin\\go.exe\" test -tags=critical -json ./tests/critical/... -count=1",
"started_at": "2026-07-13T02:33:41.5597214+00:00",
"finished_at": "2026-07-13T02:37:59.9600691+00:00",
"duration_seconds": 258.4,
"exit_code": 0,
"timed_out": false,
"stdout": "D:\\Dev\\engram\\.agent\\worktrees\\prc-sol-synthesis-r1\\.agent\\reports\\evidence\\production-ready\\release-gates-foundation\\critical-suite-runner\\sol-synthesis-20260713-observability-r2\\go-test.stdout.jsonl",
"stderr": "D:\\Dev\\engram\\.agent\\worktrees\\prc-sol-synthesis-r1\\.agent\\reports\\evidence\\production-ready\\release-gates-foundation\\critical-suite-runner\\sol-synthesis-20260713-observability-r2\\go-test.stderr.log"
Comment on lines +18 to +19

@coderabbitai coderabbitai Bot Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Нормализуйте пути в evidence-командах.

commands.json смешивает абсолютные пути D:\Dev\engram\... с относительным -InputPath, не фиксируя рабочий каталог. На другом хосте команда будет непереносимой, а артефакт раскрывает локальную структуру рабочей машины. Сохраняйте repo-relative пути и явно записывайте working_directory, либо используйте стабильные идентификаторы артефактов.

Also applies to: 27-34, 40-41

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
@.agent/reports/evidence/production-ready/release-gates-foundation/critical-suite-runner/sol-synthesis-20260713-observability-r2/commands.json
around lines 18 - 19, Normalize the evidence command records around the command
metadata and stdout/stderr artifact references: replace host-specific absolute
paths with repository-relative paths, explicitly record the working_directory,
and apply the same change to the additionally referenced entries. Preserve
stable artifact identification while ensuring commands are portable across hosts
and do not expose local machine structure.

},
{
"name": "critical-json-parser",
"executable": "C:\\Program Files\\PowerShell\\7\\pwsh.exe",
"arguments": [
"-NoProfile",
"-File",
"D:\\Dev\\engram\\.agent\\worktrees\\prc-sol-synthesis-r1\\scripts\\production-gates\\assert-go-test-json.ps1",
"-InputPath",
".agent\\reports\\evidence\\production-ready\\release-gates-foundation\\critical-suite-runner\\sol-synthesis-20260713-observability-r2\\go-test.stdout.jsonl",
"-SummaryPath",
".agent\\reports\\evidence\\production-ready\\release-gates-foundation\\critical-suite-runner\\sol-synthesis-20260713-observability-r2\\go-test-summary.json",
"-FailOnUnexpectedSkip"
],
"command": "\"C:\\Program Files\\PowerShell\\7\\pwsh.exe\" -NoProfile -File \"D:\\Dev\\engram\\.agent\\worktrees\\prc-sol-synthesis-r1\\scripts\\production-gates\\assert-go-test-json.ps1\" -InputPath \".agent\\reports\\evidence\\production-ready\\release-gates-foundation\\critical-suite-runner\\sol-synthesis-20260713-observability-r2\\go-test.stdout.jsonl\" -SummaryPath \".agent\\reports\\evidence\\production-ready\\release-gates-foundation\\critical-suite-runner\\sol-synthesis-20260713-observability-r2\\go-test-summary.json\" -FailOnUnexpectedSkip",
"started_at": "2026-07-13T02:37:59.9725318+00:00",
"finished_at": "2026-07-13T02:38:00.6718968+00:00",
"duration_seconds": 0.699,
"exit_code": 0,
"timed_out": false,
"stdout": "D:\\Dev\\engram\\.agent\\worktrees\\prc-sol-synthesis-r1\\.agent\\reports\\evidence\\production-ready\\release-gates-foundation\\critical-suite-runner\\sol-synthesis-20260713-observability-r2\\json-parser.stdout.log",
"stderr": "D:\\Dev\\engram\\.agent\\worktrees\\prc-sol-synthesis-r1\\.agent\\reports\\evidence\\production-ready\\release-gates-foundation\\critical-suite-runner\\sol-synthesis-20260713-observability-r2\\json-parser.stderr.log"
}
]
Loading
Loading