Skip to content

fix silver and souls index in UnderworldResourceType struct - #258

Merged
the-marenga merged 1 commit into
the-marenga:mainfrom
tjira:main
Aug 9, 2026
Merged

the-marenga merged 1 commit into
the-marenga:mainfrom
tjira:main

Conversation

@tjira

@tjira tjira commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

The indices of silver and souls were swapped. This commit fixes the bug so that UnderworldCollect collects the correct resources.

The indices of silver and souls were swapped. This commit fixes the bug
so that UnderworldCollect collects the correct resources.
@the-marenga

Copy link
Copy Markdown
Owner

Thanks! I think the reason why I had this enum order is because that is the order the resources are parsed in and for most things, that is then also their variant ordering. In this case though, you are right, they are swapped. In theory, doing this swap behind the scenes (in request_string()) could be a less of a breasking change, if anyone downstream relied on the numeric value, but the main branch already contains a bunch of breaking changes, that it should be fine.

Thanks again and good luck with your rsfb bot!

@the-marenga
the-marenga merged commit 8f6431c into the-marenga:main Aug 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants