fix silver and souls index in UnderworldResourceType struct - #258
Merged
Merged
Conversation
The indices of silver and souls were swapped. This commit fixes the bug so that UnderworldCollect collects the correct resources.
Owner
|
Thanks! I think the reason why I had this enum order is because that is the order the resources are parsed in and for most things, that is then also their variant ordering. In this case though, you are right, they are swapped. In theory, doing this swap behind the scenes (in Thanks again and good luck with your rsfb bot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The indices of silver and souls were swapped. This commit fixes the bug so that UnderworldCollect collects the correct resources.