Admin Dashboard by jasonsouza · Pull Request #274 · the-difference-engine/back-yards-coffee-app

jasonsouza · 2018-03-13T01:07:43Z

This pull request will add the admin page for employees and admins to have access to the following dashboards:

Other Tasks:

Authenticate admin page #190 Add Authentication for admin dashbaord
Create custom navbar for admin page
Add Admin Panel button to BOTY navbar that directs employee to admin page when employee is logged in #196 Admin Panel navbar button

houndci-bot · 2018-03-13T01:07:51Z

+    :recieving_hours,
+    :days_closed,
+    :is_approved,
+    :is_rejected,


Avoid comma after the last item of an array.

houndci-bot · 2018-03-13T01:07:51Z

+  # FORM_ATTRIBUTES
+  # an array of attributes that will be displayed
+  # on the model's form (`new` and `edit`) pages.
+  FORM_ATTRIBUTES = [


Use %i or %I for an array of symbols.

houndci-bot · 2018-03-13T01:07:51Z

+    :recieving_hours,
+    :days_closed,
+    :is_approved,
+    :is_rejected,


Avoid comma after the last item of an array.

houndci-bot · 2018-03-13T01:07:51Z

+
+  # SHOW_PAGE_ATTRIBUTES
+  # an array of attributes that will be displayed on the model's show page.
+  SHOW_PAGE_ATTRIBUTES = [


Use %i or %I for an array of symbols.

houndci-bot · 2018-03-13T01:07:51Z

+    :customer,
+    :id,
+    :business_name,
+    :contact_name,


Avoid comma after the last item of an array.

houndci-bot · 2018-03-13T01:07:52Z

+
+  # SHOW_PAGE_ATTRIBUTES
+  # an array of attributes that will be displayed on the model's show page.
+  SHOW_PAGE_ATTRIBUTES = [


Use %i or %I for an array of symbols.

houndci-bot · 2018-03-13T01:07:52Z

+    :category,
+    :id,
+    :name,
+    :description,


Avoid comma after the last item of an array.

houndci-bot · 2018-03-13T01:07:52Z

+  #
+  # By default, it's limited to four items to reduce clutter on index pages.
+  # Feel free to add, remove, or rearrange items.
+  COLLECTION_ATTRIBUTES = [


Use %i or %I for an array of symbols.

houndci-bot · 2018-03-13T01:07:52Z

+    description: Field::Text,
+    price: Field::String.with_options(searchable: false),
+    created_at: Field::DateTime,
+    updated_at: Field::DateTime,


Avoid comma after the last item of a hash.

houndci-bot · 2018-03-13T01:07:53Z

@@ -0,0 +1,60 @@
+require "administrate/base_dashboard"


Prefer single-quoted strings when you don't need string interpolation or special symbols.

mistake

houndci-bot · 2018-03-22T01:43:27Z

+            visit '/admin'
+            expect(current_path).to eq(admin_root_path)
+        end
+    end


end at 14, 4 is not aligned with RSpec.feature "Admin dashboard" do at 3, 0.

houndci-bot · 2018-03-22T01:43:27Z

+            # customer = create(:customer)
+        end
+        it 'logs in as admin' do
+            visit '/admin'


Use 2 (not 4) spaces for indentation.

houndci-bot · 2018-03-22T01:43:27Z

+            # employee = create(:employee)
+            # customer = create(:customer)
+        end
+        it 'logs in as admin' do


Inconsistent indentation detected.

houndci-bot · 2018-03-22T01:43:27Z

+        before :each do
+            admin = create(:admin)
+            # employee = create(:employee)
+            # customer = create(:customer)


Incorrect indentation detected (column 12 instead of 10).

houndci-bot · 2018-03-22T01:43:27Z

+RSpec.feature "Admin dashboard" do
+    context 'visit admin page before logging in'
+        before :each do
+            admin = create(:admin)


Use 2 (not 4) spaces for indentation.
Useless assignment to variable - admin.

houndci-bot · 2018-03-22T01:43:28Z

@@ -0,0 +1,14 @@
+require "rails_helper"
+
+RSpec.feature "Admin dashboard" do


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-03-22T01:43:28Z

@@ -0,0 +1,14 @@
+require "rails_helper"


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-03-22T01:43:28Z

    password_confirmation '12345678'
  end
+  factory :admin, :class => 'Employee' do
+    sequence(:email){ |n| "employeedoe1#{n}@example.com" }


Space missing to the left of {.

houndci-bot · 2018-03-22T01:43:28Z

    password '12345678'
    password_confirmation '12345678'
  end
+  factory :admin, :class => 'Employee' do


Use the new Ruby 1.9 hash syntax.

houndci-bot · 2018-03-22T01:43:28Z

+    :recieving_hours,
+    :days_closed,
+    :is_approved,
+    :is_rejected,


Avoid comma after the last item of an array.

houndci-bot · 2018-03-23T00:02:33Z

+    :recieving_hours,
+    :days_closed,
+    :is_approved,
+    :is_rejected,


Avoid comma after the last item of an array.

houndci-bot · 2018-03-23T00:19:46Z

+        # it 'logs in as admin' do
+        #     visit '/admin'
+        #     expect(current_path).to eq(admin_root_path)
+        # end


Incorrect indentation detected (column 8 instead of 2).

houndci-bot · 2018-03-23T00:19:46Z

+    #     end
+    #     it 'not logged in' do
+    #         visit '/admin'
+    #     end


Incorrect indentation detected (column 4 instead of 8).

houndci-bot · 2018-03-23T00:19:46Z

+    :recieving_hours,
+    :days_closed,
+    :is_approved,
+    :is_rejected,


Avoid comma after the last item of an array.

houndci-bot · 2018-03-23T00:19:46Z

+        # it 'logs in as admin' do
+        #     visit '/admin'
+        #     expect(current_path).to eq(admin_root_path)
+        # end


Incorrect indentation detected (column 8 instead of 2).

houndci-bot · 2018-03-23T00:19:46Z

+    #     end
+    #     it 'not logged in' do
+    #         visit '/admin'
+    #     end


Incorrect indentation detected (column 4 instead of 8).

houndci-bot · 2018-03-23T00:19:46Z

+    :recieving_hours,
+    :days_closed,
+    :is_approved,
+    :is_rejected,


Avoid comma after the last item of an array.

…ck-yards-coffee-app into admin-dashboard

…ngine/back-yards-coffee-app into admin-dashboard

houndci-bot · 2018-03-27T00:56:25Z

@@ -1,5 +1,5 @@
 class Customer < ApplicationRecord
-
+  has_many :orders


Specify a :dependent option.

houndci-bot · 2018-03-27T00:56:26Z

+    before_action :authenticate_admin
+
+    def authenticate_admin
+      redirect_to "/employees/sign_in" unless current_employee


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-03-27T00:56:26Z

-    plan_opts.map{|sub| "#{sub.metadata.frequency} / #{number_to_currency(sub.amount.to_f / 100)} per bag" }
+
+    plans.sort!{|a,b| freq[a.metadata.frequency] <=> freq[b.metadata.frequency] }
+    plans.map{|sub| "#{sub.metadata.frequency} / #{number_to_currency(sub.amount.to_f / 100)} per bag" }


Space missing to the left of {.
Space between { and | missing.

houndci-bot · 2018-03-27T00:56:26Z

-    plan_opts.sort!{|a,b| freq[a.metadata.frequency] <=> freq[b.metadata.frequency] }
-    plan_opts.map{|sub| "#{sub.metadata.frequency} / #{number_to_currency(sub.amount.to_f / 100)} per bag" }
+
+    plans.sort!{|a,b| freq[a.metadata.frequency] <=> freq[b.metadata.frequency] }


Space missing to the left of {.
Space between { and | missing.
Space missing after comma.

houndci-bot · 2018-03-27T00:56:26Z

+    :recieving_hours,
+    :days_closed,
+    :is_approved,
+    :is_rejected,


Avoid comma after the last item of an array.

Add "Admin Panel" button to navbar for employees that are logged in

…ngine/back-yards-coffee-app into admin-dashboard

houndci-bot · 2018-04-24T01:23:40Z

    password_confirmation '12345678'
  end
+  factory :admin, :class => 'Employee' do
+    sequence(:email){ |n| "employeedoe1#{n}@example.com" }


Layout/SpaceBeforeBlockBraces: Space missing to the left of {.

houndci-bot · 2018-04-24T01:23:40Z

    password '12345678'
    password_confirmation '12345678'
  end
+  factory :admin, :class => 'Employee' do


Style/HashSyntax: Use the new Ruby 1.9 hash syntax.

houndci-bot · 2018-04-24T01:23:40Z

+    :category,
+    :name,
+    :description,
+    :price,


Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array.

houndci-bot · 2018-04-24T01:23:40Z

+  # FORM_ATTRIBUTES
+  # an array of attributes that will be displayed
+  # on the model's form (`new` and `edit`) pages.
+  FORM_ATTRIBUTES = [


Style/SymbolArray: Use %i or %I for an array of symbols.

houndci-bot · 2018-04-24T01:23:40Z

+    :description,
+    :price,
+    :created_at,
+    :updated_at,


Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array.

houndci-bot · 2018-04-24T01:23:41Z

+  # FORM_ATTRIBUTES
+  # an array of attributes that will be displayed
+  # on the model's form (`new` and `edit`) pages.
+  FORM_ATTRIBUTES = [


Style/SymbolArray: Use %i or %I for an array of symbols.

houndci-bot · 2018-04-24T01:23:41Z

+    :grind_id,
+    :sku,
+    :name,
+    :price,


Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array.

houndci-bot · 2018-04-24T01:23:41Z

+
+  # SHOW_PAGE_ATTRIBUTES
+  # an array of attributes that will be displayed on the model's show page.
+  SHOW_PAGE_ATTRIBUTES = [


Style/SymbolArray: Use %i or %I for an array of symbols.

houndci-bot · 2018-04-24T01:23:42Z

+    :customer,
+    :order,
+    :id,
+    :created_at,


Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array.

houndci-bot · 2018-04-24T01:23:42Z

+  #
+  # By default, it's limited to four items to reduce clutter on index pages.
+  # Feel free to add, remove, or rearrange items.
+  COLLECTION_ATTRIBUTES = [


Style/SymbolArray: Use %i or %I for an array of symbols.

initial dashboard install

b2a7038

houndci-bot reviewed Mar 13, 2018

View reviewed changes

misternu previously approved these changes Mar 15, 2018

View reviewed changes

jasonsouza added the WIP label Mar 15, 2018

Added admin authentication and view

6273451

houndci-bot reviewed Mar 22, 2018

View reviewed changes

fixing admin authentication

80ad8fa

houndci-bot reviewed Mar 23, 2018

View reviewed changes

blowing away unfinished tests

3e08416

houndci-bot reviewed Mar 23, 2018

View reviewed changes

jonathanlmartinez and others added 6 commits March 22, 2018 19:58

adds admin link

4fb08aa

Add spec for admin button

736a938

Merge branch 'admin-dashboard' of github.com:the-difference-engine/ba…

484c061

…ck-yards-coffee-app into admin-dashboard

Merge branch 'admin-dashboard' of https://github.com/the-difference-e…

43a76dd

…ngine/back-yards-coffee-app into admin-dashboard

hound typos

6f757d2

remove unused dashboards

cac2d6f

houndci-bot reviewed Mar 27, 2018

View reviewed changes

jasonsouza and others added 2 commits March 26, 2018 19:57

Merge pull request #288 from the-difference-engine/admin-redirect

369563d

Add "Admin Panel" button to navbar for employees that are logged in

Merge branch 'admin-dashboard' of https://github.com/the-difference-e…

3ef1252

…ngine/back-yards-coffee-app into admin-dashboard

houndci-bot reviewed Apr 24, 2018

View reviewed changes

		@@ -0,0 +1,14 @@
		require "rails_helper"

		RSpec.feature "Admin dashboard" do

		@@ -1,5 +1,5 @@
		class Customer < ApplicationRecord

		has_many :orders

Uh oh!

Conversation

jasonsouza commented Mar 13, 2018 • edited by jklockri Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

jasonsouza commented Mar 13, 2018 •

edited by jklockri

Loading