Task #94: BCTC consistency check — flag extract vs DB history - #76
Merged
thanhhale288 merged 1 commit intoAug 19, 2026
Merged
Conversation
…ent overwrite - backend/app/services/bctc_consistency.py: compare extract fields vs latest annual FinancialReport per ticker; flag mismatch ≥10%, warn on null sides; never overwrites DB. - POST /api/benchmark/consistency: endpoint returning ConsistencyReport JSON. - Schema: BctcConsistencyIn / BctcConsistencyOut / BctcConsistencyFlagOut. - tests/benchmark/test_bctc_consistency.py: 10 unit tests (all pass). - FE: api.benchmarkConsistency() helper; BenchmarkConsistencyBanner shows warning only on mismatch flags (silent when no DB record or all ok). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bctc_consistency.py: So sánh extract fields (từ upload/prefill) vớiFinancialReportgần nhất trong DB cho cùng ticker; flag lệch ≥ 10%; không overwrite im lặng.POST /api/benchmark/consistency: Nhận{ ticker, fields }, trảConsistencyReportvới per-field flags (ok/warn/mismatch).BenchmarkConsistencyBanner: Hiển thị banner cảnh báo khi cómismatchsau khi nạp prefill. Im lặng khi không có DB record hoặc tất cả ok.Test plan
pytest tests/benchmark/test_bctc_consistency.py— 10 passedpytest tests/benchmark/— 106 passednpm run buildtrongfrontend/— ✓ no errorsMade with Cursor