rounding out some missing stuff in canvas implementation#37
Open
kris-watts-gravwell wants to merge 1 commit into
Open
rounding out some missing stuff in canvas implementation#37kris-watts-gravwell wants to merge 1 commit into
kris-watts-gravwell wants to merge 1 commit into
Conversation
kris-watts-gravwell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a crash triangulation.go:137 as well as provides some missing abstractions needed for some color support.
These changes let me render some subsets of vega charts in pure Go using a javascript runtime engine.
See: https://github.com/gravwell/govega as an example for why these changes are needed.