ci: switch release automation to GitHub token#14
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41cdae87ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id: release | ||
| with: | ||
| token: ${{ secrets.RELEASE_PLEASE_TOKEN }} | ||
| token: ${{ github.token }} |
There was a problem hiding this comment.
Use an automation token for release PRs
For release-please PRs created or updated by this step, switching from the PAT secret to github.token means the repository's Check workflow (.github/workflows/check.yml, on: pull_request) will no longer run automatically; GitHub puts pull_request runs from GITHUB_TOKEN-authored PRs into an approval-required state. That leaves every release PR without automatic CI until a writer manually approves the run, which is a regression from the previous token behavior and can block any branch protection expecting the check.
Useful? React with 👍 / 👎.
|
Closing this PR because the Release Please token issue was fixed with the organization RELEASE_PLEASE_TOKEN secret. Keeping the workflow on that token preserves downstream pull_request checks for release PRs. |
Summary
Notes