Bumping to LLVM 12 with a new CMake#5
Open
dmikushin wants to merge 2 commits into
Open
Conversation
…n-source compilation of asmjit
Author
|
One thing to note: LLVM 12 has compatibility issues with C++20 standard required by some debugging features ( In this PR C++20 requirement is temporary downgraded to C++17. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, @tetzank thank you and to your coauthors for developing Coat. This PR bumps the used version of LLVM to 12, which requires to change just a couple of lines. More importantly, this PR revises the CMake build script in the following ways:
asmjitis built "in-source" together with the project, so no extra script is needed