Skip to content

[DO NOT MERGE] speech addons: e2e validation of the qvac-ext-lib-whisper.cpp repo reorg#3310

Draft
ogad-tether wants to merge 2 commits into
mainfrom
feat/speech-repo-reorg-e2e
Draft

[DO NOT MERGE] speech addons: e2e validation of the qvac-ext-lib-whisper.cpp repo reorg#3310
ogad-tether wants to merge 2 commits into
mainfrom
feat/speech-repo-reorg-e2e

Conversation

@ogad-tether

Copy link
Copy Markdown
Contributor

What

Validation-only branch — do not merge. Overlays the tts-cpp, parakeet-cpp, and whisper-cpp ports onto the reorged qvac-ext-lib-whisper.cpp tree (QIP tetherto/qvac-ext-lib-whisper.cpp#94, PR stack #93/#95/#96/#97, pinned @ d2b39049):

port old source path new source path
tts-cpp tts-cpp/ engines/tts/
parakeet-cpp parakeet-cpp/ engines/parakeet/
whisper-cpp repo root third_party/whisper.cpp/ (registry GNUInstallDirs patch dropped — absorbed into the subtree's declared delta)

Purpose: run the three speech addons' on-pr desktop pipelines from source against the reorged layout. Mobile e2e dispatched separately on this branch (integration-mobile-test-{tts-ggml, transcription-parakeet, transcription-whispercpp}).

When the reorg PRs merge, the real registry pin bump will carry these same path updates; this branch then closes unmerged.

🤖 Generated with Claude Code

…org e2e (DO NOT MERGE)

Validation branch for the repo reorg (qvac-ext-lib-whisper.cpp QIP #94,
PR stack #93/#95/#96/#97): overlay tts-cpp / parakeet-cpp / whisper-cpp
onto the reorged tree @ d2b39049 —
- tts-cpp:      SOURCE_PATH tts-cpp/      -> engines/tts/
- parakeet-cpp: SOURCE_PATH parakeet-cpp/ -> engines/parakeet/
- whisper-cpp:  SOURCE_PATH repo root     -> third_party/whisper.cpp/
  (registry GNUInstallDirs patch dropped: absorbed into the subtree
  delta, see third_party/whisper.cpp/PATCHES.md)

Overlay port descriptions are stale copies of the registry prose; the
real registry pin bump lands separately once the reorg PRs merge. This
branch exists to run the desktop + mobile e2e suites against the
reorged layout via workflow_dispatch (ref=this branch).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Review Status

Current Status: ❌ PENDING
Approvals so far: none

Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member.

@ogad-tether ogad-tether added the verified Authorize secrets / label-gate in PR workflows label Jul 17, 2026
@ogad-tether

Copy link
Copy Markdown
Contributor Author

E2E validation results (reorged tree @ d2b39049)

addon mobile e2e (Device Farm) prebuilds desktop integration
tts-ggml ✅ pass ✅ all targets ✅ 7/7 platforms (incl. linux-arm64)
transcription-parakeet ✅ pass ✅ 9/9 targets (android/ios/linux-arm64/…) ⚠️ all platforms fail in a JS test-teardown bug unrelated to this branch: delete process.env.QVAC_TEST_GGUF_SORTFORMERSTREAMING throws under the env proxy (test added 2026-07-13, PR #3231; desktop suites are label-gated so it hadn't run since). Native tests before the teardown all pass.
transcription-whispercpp ✅ pass ✅ all targets ✅ 6/7; linux-arm64 fails at runtime with GGML_ASSERT(device) in ggml-speech backend loading — matches the known linux-arm64 CPU-variants issue (armv8-a baseline / DL modules / BACKENDS_SUBDIR; fix tracked separately), not a path/layout effect: same binary passes linux-arm64 prebuild and android-arm64 on-device

Conclusion: no failure attributable to the repo reorg. The overlay ports prove the registry pin-bump path updates (engines/tts, engines/parakeet, third_party/whisper.cpp, whisper GNUInstallDirs patch absorbed into the subtree delta).

This PR stays DO-NOT-MERGE; it closes when the real registry pin bump lands after tetherto/qvac-ext-lib-whisper.cpp#95/#96/#97 merge.

🤖 Generated with Claude Code

@ogad-tether

Copy link
Copy Markdown
Contributor Author

Update on the whisper linux-arm64 integration failure: discriminated via probe #3321 — the identical GGML_ASSERT(device) failure reproduces on a source build of unmodified main (run), while main's published 0.12.0 prebuilds pass the same job (run). Conclusion: a pre-existing regression in current source-build inputs (not this branch, not the repo reorg); tracked separately. All findings on this PR now have a verified non-reorg cause.

…96-review restorations)

Revalidation pass after the #96 review changes (restored fork tests +
Java VAD bindings in the subtree, whisper-ci hardening). Port-visible
content is unchanged vs d2b39049 (tests/bindings aren't packaged), but
the pin moves so the e2e suites certify the exact trees the stack will
merge.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

License compliance — clean

No new dependency license findings in this PR.

Warn-only (shadow) mode — this check does not block merges yet.

Updated automatically by the canonical license compliance workflow.

NOTICE presence (advisory)

Missing NOTICE (advisory, does not block):

  • ./packages/embed-llamacpp/benchmarks/server
  • ./packages/embed-llamacpp/benchmarks/performance
  • ./packages/ggml-coload-smoke
  • ./packages/llm-llamacpp/benchmarks/server
  • ./packages/llm-llamacpp/benchmarks/performance
  • ./packages/fabric/test/integration
  • ./packages/transcription-whispercpp/benchmarks/server
  • ./packages/transcription-parakeet/benchmarks/server
  • ./packages/sdk/e2e
  • ./packages/vla-ggml/sim/server
  • ./.github/actions/release-merge-guard
  • ./docs/website

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — android — ✅ all tests passed (91/103, 1603s)

Config: suite=smoke · filter=(none) · exclude=(none)
Device pool: Samsung S26 Ultra - Android 16 — ☀️ highly available
View run · Artifacts: reports · Device Farm logs

@ogad-tether

Copy link
Copy Markdown
Contributor Author

Revalidation @ pin 4dd6b2e8 (post qvac-ext-lib-whisper.cpp#96-review restorations)

addon mobile e2e (Device Farm) desktop integration
tts-ggml ✅ 7/7 platforms
transcription-whispercpp ✅ 6/7 — linux-arm64 still the verified main source-build regression (unchanged)
transcription-parakeet native stages ✅ (all prebuild targets); suites still aborted by the pre-existing JS teardown bug from #3231 (unchanged)

Identical carve-outs to the first pass, both with independent non-reorg proof; everything else green on the exact trees the stack merges.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-cpp-addon-tests CI: run C++ addon tests (requires verified) run-desktop-addon-tests CI: run desktop integration tests (requires verified) verified Authorize secrets / label-gate in PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant