Skip to content

QVAC-22218 feat[api]: add Ideogram 4 diffusion support#3287

Open
maxim-smotrov wants to merge 3 commits into
tetherto:mainfrom
maxim-smotrov:feature/sdk-ideogram
Open

QVAC-22218 feat[api]: add Ideogram 4 diffusion support#3287
maxim-smotrov wants to merge 3 commits into
tetherto:mainfrom
maxim-smotrov:feature/sdk-ideogram

Conversation

@maxim-smotrov

@maxim-smotrov maxim-smotrov commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🎯 What problem does this PR solve?

  • SDK users cannot load Ideogram 4's split model layout because the unconditional diffusion companion cannot be supplied to the diffusion plugin.

📝 How does it solve it?

  • Adds uncondModelSrc to the public SD.cpp configuration and resolves it with the required Qwen3-VL and VAE companions.
  • Validates the Ideogram-only layout and wires resolved files into @qvac/diffusion-cpp 0.14.0.
  • Adds a runnable Ideogram 4 generation example.

🧪 How was it tested?

  • Bare plugin tests cover schema acceptance, companion resolution, source-field stripping, and addon wiring.
  • Error-path tests cover unsupported modes and missing LLM or VAE companions.

🔌 API Changes

A new uncondModelSrc param is required to use with Ideogram.

const modelId = await loadModel({
  modelSrc: IDEOGRAM_MODEL_URL,
  modelType: 'sdcpp-generation',
  modelConfig: {
    llmModelSrc: QWEN3_VL_MODEL_URL,
    vaeModelSrc: VAE_MODEL_URL,
    uncondModelSrc: IDEOGRAM_UNCOND_MODEL_URL
  }
})

@github-actions

Copy link
Copy Markdown
Contributor

Review Status

Current Status: ❌ PENDING
Approvals so far: none

Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member.

@maxim-smotrov maxim-smotrov marked this pull request as ready for review July 15, 2026 13:06
@maxim-smotrov maxim-smotrov requested review from a team as code owners July 15, 2026 13:06
@maxim-smotrov maxim-smotrov added verified Authorize secrets / label-gate in PR workflows test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] labels Jul 15, 2026
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — windows — ✅ all tests passed (106/106, 676s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — android — ✅ all tests passed (94/106, 2819s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports · Device Farm logs

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — linux — ✅ all tests passed (106/106, 610s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — macos — ✅ all tests passed (106/106, 406s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — ios — ✅ all tests passed (93/106, 1123s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports · Device Farm logs

@github-actions github-actions Bot added the e2e-tested Test suite has run on this PR. Does not indicate tests pass/fail - see results in comments. label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e-tested Test suite has run on this PR. Does not indicate tests pass/fail - see results in comments. test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] verified Authorize secrets / label-gate in PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant