fix[notask]: remove OpenSSL from llama addons#3235
Draft
gianni-cor wants to merge 1 commit into
Draft
Conversation
Use the deterministic qvac-fabric port so LLM and embedding addon binaries no longer depend on system libssl or libcrypto. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Review StatusCurrent Status: ❌ PENDING Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
libsslandlibcryptothrough Fabric's exportedcpp-httplibtarget.📝 How does it solve it?
qvac-fabricregistry revision from qvac-registry-vcpkg#244.find_package(OpenSSL)workaround.@qvac/llm-llamacppto0.36.4and@qvac/embed-llamacppto0.26.3.🧪 How was it tested?
llama-targets.cmakecontains no OpenSSL target references.otool -Lreports neitherlibsslnorlibcryptofor either.barebinary.git diff --check.Dependency
Draft until qvac-registry-vcpkg#244 merges. The registry baseline SHA must then be refreshed to the commit reachable from
main.Authored by Cursor GPT-5.6 Sol using
qv-addon-pr-createandqv-qip-triage.