Skip to content

fix[notask]: remove OpenSSL from llama addons#3235

Draft
gianni-cor wants to merge 1 commit into
tetherto:mainfrom
gianni-cor:fix/addons-drop-openssl-linkage
Draft

fix[notask]: remove OpenSSL from llama addons#3235
gianni-cor wants to merge 1 commit into
tetherto:mainfrom
gianni-cor:fix/addons-drop-openssl-linkage

Conversation

@gianni-cor

Copy link
Copy Markdown
Contributor

🎯 What problem does this PR solve?

  • LLM and embedding addon binaries inherit libssl and libcrypto through Fabric's exported cpp-httplib target.
  • Builds therefore depend on whichever system OpenSSL happens to be discoverable on the build host.

📝 How does it solve it?

  • Pin both addons to the fixed qvac-fabric registry revision from qvac-registry-vcpkg#244.
  • Remove the addon-level find_package(OpenSSL) workaround.
  • Patch-bump @qvac/llm-llamacpp to 0.36.4 and @qvac/embed-llamacpp to 0.26.3.

🧪 How was it tested?

  • Built both addons on macOS arm64 against the fixed Fabric overlay.
  • Confirmed the installed llama-targets.cmake contains no OpenSSL target references.
  • Confirmed otool -L reports neither libssl nor libcrypto for either .bare binary.
  • Ran git diff --check.

Dependency

Draft until qvac-registry-vcpkg#244 merges. The registry baseline SHA must then be refreshed to the commit reachable from main.


Authored by Cursor GPT-5.6 Sol using qv-addon-pr-create and qv-qip-triage.

Use the deterministic qvac-fabric port so LLM and embedding addon binaries no longer depend on system libssl or libcrypto.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown
Contributor

Review Status

Current Status: ❌ PENDING
Approvals so far: none

Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant