QVAC-20987 feat[api]: add llm reasoning budget caps#2366
Merged
Conversation
…#144 (b9341). Signed-off-by: Marcus Edel <marcus.edel@collabora.com>
Signed-off-by: Marcus Edel <marcus.edel@collabora.com>
gianni-cor
requested changes
Jun 1, 2026
gianni-cor
requested changes
Jun 1, 2026
Signed-off-by: Marcus Edel <marcus.edel@collabora.com>
Assisted-by: GPT-5.5 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
🧪 C++ Test Coverage ReportCoverage: 📊 Detailed Coverage |
Contributor
🧪 C++ Test Coverage ReportCoverage: 📊 Detailed Coverage |
Assisted-by: GPT-5.5 Co-authored-by: Cursor <cursoragent@cursor.com>
Assisted-by: GPT-5.5 Co-authored-by: Cursor <cursoragent@cursor.com>
Assisted-by: GPT-5.5 Co-authored-by: Cursor <cursoragent@cursor.com>
Assisted-by: GPT-5.5 Co-authored-by: Cursor <cursoragent@cursor.com>
Assisted-by: GPT-5.5 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Removed quantized KVcache test for OpenCL cause openCL backend has several issues with that. tracked on the fabric PR, but will not be added here |
Contributor
Tier-based Approval Status |
Assisted-by: GPT-5.5 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
🧪 C++ Test Coverage ReportCoverage: 📊 Detailed Coverage |
Assisted-by: GPT-5.5 Co-authored-by: Cursor <cursoragent@cursor.com>
Assisted-by: GPT-5.5 Co-authored-by: Cursor <cursoragent@cursor.com>
Assisted-by: GPT-5.5 Co-authored-by: Cursor <cursoragent@cursor.com>
dev-nid
reviewed
Jun 22, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
gianni-cor
approved these changes
Jun 22, 2026
dev-nid
approved these changes
Jun 22, 2026
jesusmb1995
approved these changes
Jun 22, 2026
Contributor
|
/review |
Contributor
Tier-based Approval Status |
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
llm-llamacppreasoning-channel control more useful by allowing positivereasoning_budgetvalues to cap<think>output instead of only supporting unrestricted/disabled modes.<think>assumptions.📝 How does it solve it?
reasoning_budgetparsing so-1is unrestricted,0disables thinking, and positive integers cap the reasoning channel at that many tokens.llm-llamacpptests and platform scheduling: reasoning-budget unit/model coverage, chat-template helper coverage, tools-compact session flush fencing, continuous-batching mobile wiring, Windows/macOS skip adjustments, and VLM performance skip cleanup.🧪 How was it tested?
git diff --check upstream/main...HEAD.💥 Breaking Changes
q4_*,q5_*,q8_0,iq4_nl,tbq*,pq*) during config validation. Usef32,f16, orbf16on OpenCL, or switch to Vulkan/CPU for quantized KV-cache modes.🔌 API Changes
Positive
reasoning_budgetvalues now cap the reasoning channel.-1keeps reasoning unrestricted and0disables it.