-
-
Notifications
You must be signed in to change notification settings - Fork 625
fix: bound the reaper connect dial so the spawner backoff can retry #3839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ghaering
wants to merge
1
commit into
testcontainers:main
Choose a base branch
from
ghaering:fix/reaper-dial-timeout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+39
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| package testcontainers | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/cenkalti/backoff/v4" | ||
| ) | ||
|
|
||
| // A blackholed endpoint (SYNs dropped, no RST) must fail within the 5s dial | ||
| // bound and be classified retryable, so the spawner's 20s backoff can retry. | ||
| func TestReaperConnectDialBounded(t *testing.T) { | ||
| r := &Reaper{Endpoint: "192.0.2.1:8080"} // TEST-NET-1, not routed | ||
| start := time.Now() | ||
| _, err := r.connect(context.Background()) | ||
| elapsed := time.Since(start) | ||
|
|
||
| if err == nil { | ||
| t.Fatal("expected dial error") | ||
| } | ||
| if elapsed > 10*time.Second { | ||
| t.Fatalf("dial not bounded: took %v", elapsed) | ||
| } | ||
| s := &reaperSpawner{} | ||
| rerr := s.retryError(err) | ||
| var perm *backoff.PermanentError | ||
| if errors.As(rerr, &perm) { | ||
| t.Fatalf("timeout classified permanent, backoff would stop: %v", rerr) | ||
| } | ||
| t.Logf("dial failed after %v, retryable: %v", elapsed, err) | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift
Make the timeout regression test deterministic and enforce the five-second bound.
192.0.2.1does not guarantee a SYN timeout on every CI host. The dial can returnENETUNREACHorECONNREFUSEDimmediately.reaper.goLines 237-248 can classifyENETUNREACHas permanent, and an immediateECONNREFUSEDlets an implementation without the new timeout pass this test.Inject the dialer or dial function and block it until the child context expires. Assert a deadline or timeout error. Set the elapsed limit to five seconds plus a small scheduling margin instead of ten seconds.
🤖 Prompt for AI Agents